mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-05 04:27:55 +00:00
da0bfdbd22
subiquity_nfsroot_server and subiquity_kcmdline each have tests, but reverting the call site in mkinstall -- putting xCAT::NetworkUtils->getipaddr back in place of subiquity_nfsroot_server, which is precisely the regression the fix removes -- leaves the whole unit suite green. A helper can be perfectly covered while nothing links it to production, and that is the shape the review found. mkinstall needs a management node, so this drives the composition it performs: resolve the install server, then build the command line, or explain why not. It fails at the extraction guard until that composition is a routine that can be called, so the behavioural proof is the mutation on top of the fix, not this red alone. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>