mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-21 16:39:30 +00:00
Daniel Hilst
d94059e1b5
reg_linux_diskless_installation_flat corrupts the KVM machine type of the compute node, checks that the node does not boot, and restores it. The restore picks the machine type from a ladder that names ppc64 and x86_64 only. On any other architecture str3 stays empty, so chdef writes an empty vmothersetting and the check that follows it, "vmothersetting contains machine", fails. The remove path reads the same ladder and compares against an empty string, which bash reports as "unary operator expected". diskless_flat_vmothersetting_machine.t lifts both commands out of the case file and runs them with lsdef and chdef shadowed, so the assertions read the value the case would write. It fails five of fifteen assertions, all of them riscv64. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
See unit/README.md and bats/README.md for the detailed rules for
each unit-test suite.