2
0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-09-05 12:37:54 +00:00
Files
xcat-core/xCAT-server/lib
Vinícius Ferrão 7759714c5a refactor(xcatd): drop the XML parser options that never reach the parser
Both parser constructors passed a list of options to XML::Parser as an array
reference:

    XML::Parser->new(Style => 'Tree', [ load_ext_dtd => 0, ... ]);

XML::Parser->new takes a flat list of pairs. The reference is one value in that
list, so the constructor reads the pairs as Style => 'Tree' and then the
reference as the name of an option with no value. Every option inside the
reference is dropped. The names are also the names that XML::LibXML uses, not
the names that XML::Parser uses, so the parser would ignore them even if it
received them.

The options therefore never did anything, and they give the reader the
impression that the parser refuses an external entity because of them. The
handler on the next line is what refuses an external entity.

Remove them. Behaviour does not change.
2026-09-01 21:49:11 -03:00
..