mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-05 04:27:55 +00:00
Vinícius Ferrão
cef02c6901
The two tests for this export never loaded the plugin. Each held a copy of the logic it checked. One copied the merge that builds the node and interface hashes. The other copied the payload the command sends. The only link to the plugin was a set of regular expressions over its source. The plugin could therefore change its merge or its payload while every assertion about behavior still passed. The expressions that were meant to catch that break when the source is only reformatted. Load the plugin and call makeconfluentcfg. The tables it reads and the client it sends to answer the calls the command makes. The driver disk test already does this for its own plugin. Every assertion now checks what the command emits. The reason recorded for the copy was wrong. The plugin loads with the library paths alone. It needs no management node and no database. The two files become one because they share that harness. Two files would put the same copy back in two places. 22 of the 37 assertions fail against the plugin as it was before this export existed.