Vinícius Ferrão
c7b442598e
xcat_apt_get is sourced from xcatpkgutils.sh and called with a shadowed apt-get that records its environment and arguments. The apt block of ospkgs and the two apt commands of otherpkgs are extracted from the scripts and executed the same way, since neither script can be sourced. Against the previous scripts 6 of the 7 tests fail: the helper does not exist, and the recorded calls carry --force-yes. Signed-off-by: Vinícius Ferrão <2031761+viniciusferrao@users.noreply.github.com>
xCAT-test/bats
Shell-script unit tests live here and run with:
bats -r xCAT-test/bats
The GitHub Actions xcat_test workflow runs this command after the Perl .t
unit tests. Use BATS for shell behavior that can be exercised from the source
tree without an installed xCAT, a live management node, or real services.
Prefer sourcing an existing shell library or sourceable script and calling the
function under test. Keep reusable install-template helpers in
xCAT-server/share/xcat/install/scripts/scriptlib, and reusable postscript
helpers in xCAT/postscripts/xcatlib.sh. Use scratch directories and shadowed
commands so tests cannot write to the host.
Extraction helpers in helpers/shell_source.bash are only for legacy code that
cannot safely be sourced yet. Do not add Perl .t tests that grep shell source
when the behavior can be tested with BATS.