mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-11-19 17:02:15 +00:00
86066cad78
Sixteen assertions on this branch matched a regular expression against the source of the code they test. Such an assertion passes when the code is moved somewhere it never runs, and fails when the file is reformatted and nothing has changed: a perltidy respace of updatenode.pm:1606 turned updatenode_ipv6_endpoint.t red with the behaviour unchanged. updatenode_ipv6_endpoint.t now runs updatenoderunps and updatenodesoftware and reads the xdsh command each one dispatched. It also covers the service node name that has no usable endpoint, which the regular expressions could not reach. anaconda.pm built the debug syslog kernel arguments inline inside two large subs. Move each to its own sub, _netboot_syslog_kcmdline_args and _install_syslog_kcmdline_args, and render them in the test. An unusable server name now gives no syslog arguments, where it gave "syslog.server=" with nothing after it. pping is a program with no sub API, so the nmap and fping command building moves to xCAT::DSHCore as nmap_ping_command and fping_ping_command, and pping stays the caller that forks and execs the list. credentials_ipv6_callback.t read allowcred.awk as text, and ran gawk from a .t. The awk program is covered by xCAT-test/bats/ipv6_allowcred_awk.bats, which starts it and speaks the credential protocol to it over both families. Stubbing Socket6 and IO::Socket::INET6 in %INC also unskips the four _open_callback_socket assertions, which skipped where the suite runs. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>