mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-21 16:39:30 +00:00
Daniel Hilst
b9b66aab14
On a management node with Net::DNS below 1.36, makedns rewrites the named.conf key stanza to hmac-md5. It then signs the update with the algorithm the site table selects. named matches a TSIG key by name and by algorithm, so it rejects every update and makedns exits 1. ddns_named_key_algorithm.t drives update_namedconf over a scratch named.conf and then signs one update with the context that run produced. It asserts that the stanza keeps the algorithm the key was generated with, that the signature uses that algorithm, and that named is not restarted. Two of its five subtests fail before the fix. ddns_omapi_policy.t pinned the rewrite as correct, so its expectations move to the algorithm the key already has. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
See unit/README.md and bats/README.md for the detailed rules for
each unit-test suite.