mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-05 12:37:54 +00:00
Daniel Hilst
a5cc24c18f
DHCP backend auto-selection fails hard when the backend it prefers is not installed. The xcat metapackage's "isc-dhcp-server | kea" Depends guarantees isc-dhcp-server, while auto-selection prefers kea on 22.04+, where kea arrives only through Recommends. An apt run that skips recommends therefore leaves a node with isc only, auto picks the absent kea, and makedhcp errors out on a freshly installed management node (#7710). makedhcp -q re-enters omshell on the very releases whose write paths avoid it. xCAT already records each reservation as a static host block in dhcpd.conf on Ubuntu's ISC-limited releases because their ISC DHCP 4.4 omshell can wedge at 100% CPU and never be reaped, but listnode still called _omshell_query_host unconditionally. Both host-block scans also match the node name loosely: /\Q$node\E\b.* start$/ matches at a hyphen, so "compute" matches the "compute-01" marker -- a query can answer with another node's address and a delete can remove another node's reservation. Cover all three: the auto-selection fallback, a query answered from dhcpd.conf without omshell, and exact node-name matching for both the query and the delete. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>