mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-04 20:17:55 +00:00
Daniel Hilst
a07b1f8ae4
defer_syncfiles_to_postboot has tests, but deleting the whole block out of makescript -- the provmethod override and the call -- left the entire unit suite green. That is precisely how the wrong deletion shipped two commits ago: the override was removed on the mistaken grounds that %image_hash never carries a provmethod, and nothing noticed. makescript needs a management node and a database, so the block is lifted out and eval'd into a scratch package, driven with the hash makescript actually builds. What it pins is the resolution -- an osimage NAME becoming the osimage's real provmethod -- and that the resolved value is what reaches the helper. Verified by mutation rather than by shape: an override that is present but never fires reddens 1-3, and passing $provmethod instead of $effective_provmethod reddens 2-3. Deleting the block, or the override, trips the extraction guard instead, which is a loud failure rather than a silent pass. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>