mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-10-21 23:28:19 +00:00
Daniel Hilst
c6fc094c93
The Perl tests of the OpenEmbedded Genesis image ran its shell scripts
and C programs through system(), qx, pipes and fork, wrote fake
commands through copied read_file and write_file helpers, and matched
regexes against shell and C source. Many rejections checked only a
non-zero exit, so an earlier, unrelated failure also passed. The
quality gate judged 91% of their 762 checks bad.
The shell and C checks move to bats in xCAT-test/bats. The C programs
are compiled there and run: the plain console, test drivers for the
shared status view and the shell launcher, and genesis-udp-send against
a loopback listener. Each rejection now matches the message of its own
guard. The .t files keep the artifact checks (kas, recipes, kernel
fragments, units, README), read with XCAT::Test::File. Test files left
with no checks are deleted.
Claim map (file -> where its claims went):
- go_xcat_uninstall_installed_only.t -> go_xcat_uninstall_installed_only.bats
- genesis_readme_paths.t, genesis_base_sources_staged.t -> kept in the
.t (README read by slurp_repo_file, tarball read by Archive::Tar)
- genesis_openembedded_{export,hardware,runtime}.t -> the bats file of
the same name
- genesis_openembedded_{bmcsetup,metrics,extensions,qeth,actions,
discovery}.t -> scripts to the bats file of the same name, recipes
and units kept in the .t
- genesis_openembedded_console.t -> built and run checks, state.c,
plain_ui.c and shell.c to genesis_openembedded_console.bats; Newt
source checks kept in the .t
- genesis_openembedded.t -> oe/build to genesis_openembedded_build.bats;
shell matches to the runtime, hardware and extensions bats; console
matches to the console bats or the console .t; artifacts kept
Red proof: every moved or new test was run against a mutated copy of
the code it covers and went red, for example: rpm -q not checked,
tar without --mtime, VEX report not exported, support dir after PATH,
digest check off, layer2 forced, wildcard device allowed, arguments
eval'd, tcp probe skipped, SOURCE_PORT 302, AF_INET only, stage timer
compared, launch error ignored, kas run twice, status written in place.
One mutation stayed green: tar without --owner=0 when the test runs as
root.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
37 lines
1.3 KiB
Perl
37 lines
1.3 KiB
Perl
#!/usr/bin/env perl
|
|
use strict;
|
|
use warnings;
|
|
|
|
use FindBin;
|
|
use lib "$FindBin::Bin/../lib";
|
|
use Test::More;
|
|
|
|
use XCAT::Test::File qw(slurp_repo_file);
|
|
|
|
# The systemd unit and the recipe are the artifact. genesis-action is shell and is tested in
|
|
# xCAT-test/bats/genesis_openembedded_actions.bats.
|
|
|
|
my $INIT = 'xCAT-genesis-base/oe/meta-xcat-genesis/recipes-core/xcat-genesis-init';
|
|
|
|
my $service = slurp_repo_file("$INIT/files/xcat-genesis-action.service");
|
|
like( $service, qr/^ConditionKernelCommandLine=xcatd$/m,
|
|
'action execution requires an xCAT boot' );
|
|
like( $service, qr/^Requires=xcat-genesis-register\.service$/m,
|
|
'action execution requires registration' );
|
|
unlike( $service, qr/^Restart=/m,
|
|
'a fatal action remains failed for diagnosis' );
|
|
unlike( $service, qr/^StartLimitIntervalSec=/m,
|
|
'the action service has no unlimited restart policy' );
|
|
|
|
my $recipe = slurp_repo_file("$INIT/xcat-genesis-init_1.0.bb");
|
|
like( $recipe, qr/\bxcat-genesis-discovery\b/,
|
|
'action runtime includes discovery support' );
|
|
like( $recipe, qr/file:\/\/genesis-action/,
|
|
'action executor is packaged' );
|
|
like( $recipe, qr/file:\/\/genesis-network-refresh/,
|
|
'discovery network refresh is packaged' );
|
|
like( $recipe, qr/\bxcat-genesis-action\.service\b/,
|
|
'action service is enabled' );
|
|
|
|
done_testing();
|