mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-10-22 15:48:14 +00:00
Daniel Hilst
0eaed3119f
A sweep of xCAT-test/autotest/testcase for the shape found in
nodeset_shell_lzma -- a check whose expected pattern also appears in its own
command -- returns 274 matches. In six of them the self-matching check is the
only proof of the property the case exists to test, so the case is green when
the property is absent.
xdcp_RP and xdcp_R write "test1" into /tmp/xdcp/test1/test1.txt, then read it
back and assert "output=~test1". The path repeats the content, so "cat:
/tmp/xdcp/test1/test1.txt: No such file or directory" matches. These are the
only checks that read the copied bytes; the earlier ls checks prove the name
arrived, not the content. updatenode_diskful_syncfiles_dir has the same shape
for the files updatenode -F syncs.
lsxcatd_null asserts "output=~lsxcatd" on "lsxcatd", which the shell's
"lsxcatd: command not found" satisfies.
export_import_multiple_osimages_by_dir asserts "output=~site" on "ls -R
/opt/inventory/site", which "ls: cannot access '/opt/inventory/site'"
satisfies.
The copied and synced files now carry a content marker that the path does not
repeat, so the check reads the bytes and not the file name. lsxcatd_null
asserts a line of the usage text, and the two inventory listings assert the
exported osimage name.
Verified with the runcmd and check-evaluation code lifted out of
xCAT-test/xcattest. Every replaced check is green both when the behaviour is
present and when it is removed. Every new check is green with the behaviour
present and red without it.
Seven further self-matching checks in xdcp/cases0 ("ls -l /tmp/test1.txt"
with "output=~test1") measure nothing but sit behind a sound "ls -l /tmp"
check, so a real failure is already caught. They are left for a decision.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
(cherry picked from commit 194dd4ec6cbf3dc9d1e341b69445cbd3baa27b34)