Eight checks in the selinux testcases asserted ausearch output =~ "<no matches>", which is zero denials of any kind in the window. A cluster denies things xCAT has nothing to do with. On an idle enforcing management node httpd asks the kernel for net_admin on itself every ten seconds, and the base policy carries no dontaudit rule for that shape. One node logged 1034 denials in a day, 817 of them that one shape. So the assertion cannot pass once ausearch is called correctly, and before --input-logs was added it could not fail. selinux_avc_check.sh keeps the denials whose subject program or object path belongs to xCAT and counts those. The cases assert XCAT_AVC=0. selinux_mn_labels now also plants a denial on purpose: it mislabels /install/postscripts/xcatdsklspost, shows httpd answering 403, and requires the check to report XCAT_AVC=[1-9] before restoring the label. A counting method with no positive control cannot be trusted to find anything. restorecon -RnvF reports a difference in the SELinux user as well as the type, and the files xCAT writes carry unconfined_u. On one node -RnvF printed 12 lines over /install where -Rnv printed 2. The checks use -Rnv, which is the type they assert. The six cases were in no bundle and in no pipeline conf, so none had ever run, which is why the dead checks were not noticed. selinux.bundle and selinux_mn.bundle name them, and selinux_bundle.t fails when a case is in no bundle. Tests: selinux_avc_check.bats drives the classifier with records measured on an enforcing management node. Replacing the filter with one that keeps every record fails 4 of its 8 checks; dropping the object-path branch fails 2. selinux_bundle.t fails when selinux.bundle is removed. selinux_kickstart_template.t asserted the relabel order with a regex that matched wherever the relabel sat; it now compares line positions, and moving #SELINUXRELABEL# above the xCAT post includes fails it. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| Black-box service tests | xCAT-test/blackboxtest/ |
python3 -m unittest discover -s tests, then blackboxtest run <conf> on a management node |
| Native host tests | xCAT-test/native/*.t, xCAT-test/native/*.bats |
Selected CI cases and explicit lab runs; see native/README.md |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
blackboxtest is the odd one out: its Python unit tests and blackboxtest validate run offline like the others, but its point is the third column --
asking a management node what a booting node asks (DHCP, DNS, TFTP, HTTP,
xcatd) and asserting on the answers. It talks to the services only as a client,
so it does not depend on which DHCP server answers or on the xCAT database.
See unit/README.md, bats/README.md and blackboxtest/README.md for the
detailed rules for each suite.