mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-05 04:27:55 +00:00
Daniel Hilst
7082fabe0b
ubuntu_subiquity_boot_flip.t bound 3002 on the loopback to check it was free and skip_all'd when it was not. 3002 is the install-monitor port, so on any management node xcatd is already listening there -- which is precisely where the suite runs. The CI log for #7761 reads ubuntu_subiquity_boot_flip.t ... skipped: port 3002 is not available on the loopback interface so all 139 lines and 12 assertions never executed once, and never would have. Coverage that reports as a skip is worse than none, because the gap is invisible. Take an ephemeral port from the kernel and rewrite the extracted command to use it, in both the /dev/tcp target and the log message. The port number is not what is under test -- the retry-and-log behaviour is. The template's own port is read out of the command rather than hard-coded, and asserted to be 3002, so moving the install-monitor still leaves the file covering something instead of silently testing a port nothing uses. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>