mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-11-19 08:52:15 +00:00
6cdc48b595
Before this work xCAT stored vpd.uuid with its first three fields swapped for nodes from Genesis discovery and for KVM guests from mkvm, clonevm and rscan. vpd.uuid now holds the UUID that the operating system reports, and no row is migrated. makedhcp swaps such a row a second time, so the DUID it reserves the address for is the canonical order of the real UUID, which no client sends. The node then gets no lease and makedhcp reports nothing. Until now the problem was only described in makedhcp.8.pod. A row cannot be rewritten, because nothing tells which spelling it holds. So makedhcp reports instead. The new dhcp6_uuid_looks_byte_swapped reads the RFC 4122 version field: a swap of the first three fields moves it from the first nibble of the third field to the third nibble, and moves nothing else. A value whose version is valid only in the swapped position is therefore a row to look at. dhcp6_client_duid returns the message as a third value, and addnode6 and kea_node_reservations6 report it once for the node. Neither changes the value or the reservation. What the check cannot know: a swap leaves a valid version in the first field about half the time, so it misses those rows. It also cannot read the UUID that the node holds, so a node with a non-conformant firmware UUID can be reported for nothing. dhcp_dhcpv6_duid.t adds node cn10 and a block that holds down the detection, the double swap, and the remedy the message gives. Reading the swapped version from nibble 15 instead of 14 fails exactly the four assertions that name the report, and leaves green the five that hold the limits of the check and the four that hold the DUID values. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>