mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-10-21 07:08:12 +00:00
Daniel Hilst
698bccf493
The bats stub returned one exit code for every "chdef netboot=", and the helper calls chdef twice: once to set the method to ipxe, and once to put the saved method back. With the stub failing both, "a netboot method that cannot be put back fails the case" passed on the FORWARD failure, so removing restore_rc=1 from the restoring branch left all 18 tests green. The test named a defect it could not detect. The stub now counts its netboot calls and fails the one the test names, so the forward chdef succeeds. The test asserts that forward call is in the call log, and matches the message only the restoring branch prints. Removing restore_rc=1 now fails test 8 and no other. docs/source/advanced/ipxe/index.rst said both methods run the same boot scripts, which stopped being true when the shim line became conditional on the method. It now says what differs, and states that Secure Boot reaches netboot=ipxe only: xnba.efi is unsigned, and grub2 nodes are out of scope. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>