mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-05 04:27:55 +00:00
Daniel Hilst
5ce5edf24b
The subiquity path resolved $instserver with getipaddr and `next`ed the node when that returned nothing. For a node whose noderes.xcatmaster is unset, $instserver is the literal '!myipfn!' -- a placeholder that pxe.pm:176 and grub2.pm:129 substitute with my_ip_facing($node) when they write the boot config. Resolving it as a name always fails, so those nodes went from a working numeric nfsroot to no boot config and a "Could not resolve the install server" error. noderes.5.rst:125 documents an unset xcatmaster as supported, and anaconda.pm and sles.pm both already guard the placeholder with `unless ($instserver eq '!myipfn!')`. Exempt the placeholder, keeping the guard for a real name that does not resolve -- klibc's nfsmount still cannot resolve one of those, which is what the original commit was for. The decision moves into subiquity_nfsroot_server(), taking the resolver as an optional argument, so it can be driven directly instead of through a routine that needs a management node. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>