2
0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-11-20 09:22:17 +00:00
Files
xcat-core/xCAT-test/bats
Daniel Hilst e35e2f8e19 test(xcat-core): the Genesis SELinux checks pass when the relabel fails
stage_genesis_payload() runs restorecon and discards its exit status, so a
relabel that fails returns 0 and the kernel keeps the context of the install
tree. mknb_genesis_selinux_context.t asserted that rc, so the test held the
defect in place. It now requires the failure to reach the caller, with the
kernel path and a message that names the relabel.

selinux_context.sh reads only the output of restorecon -F -n -v, so a non-zero
exit with no output reports GENESIS_SELINUX_OK.

The helper also builds genesis.kernel.<arch> from the architecture it was
given. With legacy Genesis, mknb ppc64le resolves share/xcat/netboot/genesis/
ppc64 and writes genesis.kernel.ppc64, so the helper fails on a kernel mknb
never staged. Three ppc64le cells run this case.

genesis_kernel_selinux_context.bats drives the helper with lsdef, mknb,
selinuxenabled and restorecon shadowed and XCATROOT in a scratch tree. Three of
its four checks fail without the fix that follows, and the fourth fails when the
OpenEmbedded branch is removed.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-14 16:45:21 -03:00
..

xCAT-test/bats

Shell-script unit tests live here and run with:

bats -r xCAT-test/bats

The GitHub Actions xcat_test workflow runs this command after the Perl .t unit tests. Use BATS for shell behavior that can be exercised from the source tree without an installed xCAT, a live management node, or real services.

Prefer sourcing an existing shell library or sourceable script and calling the function under test. Keep reusable install-template helpers in xCAT-server/share/xcat/install/scripts/scriptlib, and reusable postscript helpers in xCAT/postscripts/xcatlib.sh. Use scratch directories and shadowed commands so tests cannot write to the host.

Extraction helpers in helpers/shell_source.bash are only for legacy code that cannot safely be sourced yet. Do not add Perl .t tests that grep shell source when the behavior can be tested with BATS.

Postscript sandbox prerequisites

otherpkgs_upgrade_scope.bats and routeop.bats run complete postscripts in Linux filesystem and network namespaces. Their /etc writes stay inside test fixtures. They require Bubblewrap, Bash, GNU core utilities, grep, sed, and permission to create user namespaces. The CI workflow installs Bubblewrap and enables those namespaces.

Missing prerequisites fail these tests without stopping unrelated test files. Non-Linux hosts report a skip. Set TMPDIR to a writable, executable filesystem if the default temporary directory is mounted with noexec.

go_xcat_os_release.bats, go_xcat_activation.bats and the full-script cases in postscripts_apt_get.bats use the same namespace isolation. They require bats-core 1.4 or newer. OS detection also requires GNU awk for the legacy Red Hat release parser. Postscript cases require GNU diffutils.

networkmanager_postscript.bats renders complete installation postscripts in private namespaces. It requires Bubblewrap, bats-core 1.4 or newer, user namespaces and the xCAT Perl dependencies, including DBI and DBD::SQLite.

go_xcat_os_release.bats and go_xcat_el_repo_check.bats source the complete go-xcat script. OS detection uses mawk when available, otherwise the host AWK. The two legacy Red Hat version cases use GNU awk. CI installs both interpreters. Package-manager commands are test doubles, so these cases check selection, arguments and error handling, not repository availability or package installation.

Genesis startup

genesis_ib_modules.bats and genesis_secondary_dhcp.bats run the complete doxcat script in a private filesystem and network namespace. They replace external services and device commands, then check the boot interface and the IPv4 and IPv6 DHCP requests. They do not contact a DHCP server or a BMC.

The startup cases require Linux, bats-core 1.4 or newer, Bubblewrap, Bash, GNU core utilities, grep, sed, awk and permission to create user namespaces. Missing Linux prerequisites fail these cases. Non-Linux hosts skip them. The RPM prerequisite check requires rpmspec but does not use the sandbox. Run containers with an init process to reap children created by deliberate-fault tests.

Genesis sandbox prerequisites

genesis_bmcsetup_users.bats and genesis_getadapter.bats run the complete checkout scripts with private filesystem, process, and network namespaces. They replace hardware and transport commands, not the scripts under test. The fixtures do not contact a BMC or transmit an adapter request.

These tests require Linux, bats-core 1.4 or newer, Bubblewrap, Bash, GNU core utilities, awk, grep, sed, and user namespace support. The adapter tests also require cmp from diffutils. The CI environment provides these dependencies. Missing prerequisites fail on Linux; non-Linux hosts report a skip. The temporary filesystem must allow executable files.