mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-10-22 07:38:08 +00:00
Daniel Hilst
c6fc094c93
The Perl tests of the OpenEmbedded Genesis image ran its shell scripts
and C programs through system(), qx, pipes and fork, wrote fake
commands through copied read_file and write_file helpers, and matched
regexes against shell and C source. Many rejections checked only a
non-zero exit, so an earlier, unrelated failure also passed. The
quality gate judged 91% of their 762 checks bad.
The shell and C checks move to bats in xCAT-test/bats. The C programs
are compiled there and run: the plain console, test drivers for the
shared status view and the shell launcher, and genesis-udp-send against
a loopback listener. Each rejection now matches the message of its own
guard. The .t files keep the artifact checks (kas, recipes, kernel
fragments, units, README), read with XCAT::Test::File. Test files left
with no checks are deleted.
Claim map (file -> where its claims went):
- go_xcat_uninstall_installed_only.t -> go_xcat_uninstall_installed_only.bats
- genesis_readme_paths.t, genesis_base_sources_staged.t -> kept in the
.t (README read by slurp_repo_file, tarball read by Archive::Tar)
- genesis_openembedded_{export,hardware,runtime}.t -> the bats file of
the same name
- genesis_openembedded_{bmcsetup,metrics,extensions,qeth,actions,
discovery}.t -> scripts to the bats file of the same name, recipes
and units kept in the .t
- genesis_openembedded_console.t -> built and run checks, state.c,
plain_ui.c and shell.c to genesis_openembedded_console.bats; Newt
source checks kept in the .t
- genesis_openembedded.t -> oe/build to genesis_openembedded_build.bats;
shell matches to the runtime, hardware and extensions bats; console
matches to the console bats or the console .t; artifacts kept
Red proof: every moved or new test was run against a mutated copy of
the code it covers and went red, for example: rpm -q not checked,
tar without --mtime, VEX report not exported, support dir after PATH,
digest check off, layer2 forced, wildcard device allowed, arguments
eval'd, tcp probe skipped, SOURCE_PORT 302, AF_INET only, stage timer
compared, launch error ignored, kas run twice, status written in place.
One mutation stayed green: tar without --owner=0 when the test runs as
root.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
34 lines
1.2 KiB
Perl
34 lines
1.2 KiB
Perl
#!/usr/bin/env perl
|
|
use strict;
|
|
use warnings;
|
|
|
|
use FindBin;
|
|
use lib "$FindBin::Bin/../lib";
|
|
use Test::More;
|
|
|
|
use XCAT::Test::File qw(slurp_repo_file);
|
|
|
|
# The recipes are the artifact: bitbake reads these lines to build the image. The wrapper and
|
|
# the legacy BMC scripts are shell and are tested in xCAT-test/bats/genesis_openembedded_bmcsetup.bats.
|
|
|
|
my $META = 'xCAT-genesis-base/oe/meta-xcat-genesis';
|
|
my $recipe_text = slurp_repo_file(
|
|
"$META/recipes-xcat/xcat-genesis-bmcsetup/xcat-genesis-bmcsetup_1.0.bb");
|
|
|
|
for my $source (qw(bmcsetup getipmi remoteimmsetup updateflag.awk)) {
|
|
like( $recipe_text, qr/file:\/\/\Q$source\E\b/,
|
|
"$source is sourced from the existing Genesis implementation" );
|
|
}
|
|
like( $recipe_text,
|
|
qr{\$\{libexecdir\}/xcat/genesis/actions/bmcsetup},
|
|
'bmcsetup is installed as an approved action' );
|
|
like( $recipe_text, qr/\bxcat-genesis-discovery\b/,
|
|
'the BMC action uses the credential callback socket' );
|
|
like( $recipe_text, qr/\bgawk\b/,
|
|
'the legacy status callback has its required awk implementation' );
|
|
like( slurp_repo_file("$META/recipes-core/images/xcat-genesis-image.bb"),
|
|
qr/\bxcat-genesis-bmcsetup\b/,
|
|
'the base Genesis image includes BMC setup' );
|
|
|
|
done_testing();
|