xcatd.service sets XCATROOT and PATH to the literal /opt/xcat. The previous ExecStart sourced xcat.sh, which %post generates from RPM_INSTALL_PREFIX0, so a relocated package got its own prefix. With the package installed under /srv/xcat the daemon symlink reaches /srv/xcat/sbin/xcatd and the Perl search path still names /opt/xcat, so xcatd cannot load its own modules unless the administrator overrides the environment or a default installation is left behind. %post writes /etc/xcat/xcatroot.env with XCATROOT and PATH built from RPM_INSTALL_PREFIX0, and the unit reads it with EnvironmentFile. The order is the default in the unit, then that file, then /etc/sysconfig/xcat, so the recorded prefix replaces the default and the site file keeps the last word. ExecStart stays a direct call, so the kernel still enters xcat_t on the xcatd script. %preun removes the file on erase. The file is not in %files, so rpm --verify is unaffected. xcatd_relocated_startup.t fails 3 checks of its /srv/xcat subtest without this change. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| Black-box service tests | xCAT-test/blackboxtest/ |
python3 -m unittest discover -s tests, then blackboxtest run <conf> on a management node |
| Native host tests | xCAT-test/native/*.t, xCAT-test/native/*.bats |
Selected CI cases and explicit lab runs; see native/README.md |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
blackboxtest is the odd one out: its Python unit tests and blackboxtest validate run offline like the others, but its point is the third column --
asking a management node what a booting node asks (DHCP, DNS, TFTP, HTTP,
xcatd) and asserting on the answers. It talks to the services only as a client,
so it does not depend on which DHCP server answers or on the xCAT database.
See unit/README.md, bats/README.md and blackboxtest/README.md for the
detailed rules for each suite.