mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-22 09:32:27 +00:00
Daniel Hilst
3a715962d8
genesis_ubuntu_build_root.t called BAIL_OUT at four places where an extraction stopped matching. prove stops every remaining file on a bail-out, so one stale regex in this file hides the results of the tests that would have run after it. die is just as loud and costs only this file. Four comments in the same file also explained more than the code hides: the header retold the failure the test exists for, two narrated the two helper subroutines, and one traced the lease failure across doxcat, the image and the node. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
89 lines
3.6 KiB
Perl
Executable File
89 lines
3.6 KiB
Perl
Executable File
#!/usr/bin/env perl
|
|
# The Ubuntu Genesis build root must carry every command the Ubuntu dracut module marks
|
|
# mandatory. dracut_install reports a missing command and returns 0, so a hole in the image
|
|
# does not fail the build.
|
|
#
|
|
# The mandatory list comes from RUNNING the module: module-setup.sh is sourced with
|
|
# dracut_install shadowed, _dracut_install_opt neutralised, and install() called. The
|
|
# package list comes from evaluating the REQUIRED_PACKAGES assignment in the build script.
|
|
use strict;
|
|
use warnings;
|
|
|
|
use File::Temp qw(tempdir);
|
|
use FindBin;
|
|
use lib "$FindBin::Bin/../lib";
|
|
use Test::More;
|
|
|
|
use XCAT::Test::File qw(repo_path);
|
|
|
|
my $builder = repo_path('xCAT-genesis-builder/builddeb-genesis-base');
|
|
my $module = repo_path('xCAT-genesis-builder/dracut_105/ubuntu/module-setup.sh');
|
|
plan skip_all => 'builddeb-genesis-base not found' unless -f $builder;
|
|
plan skip_all => 'ubuntu module-setup.sh not found' unless -f $module;
|
|
plan tests => 8;
|
|
|
|
# Mandatory commands a minimal Ubuntu server root does NOT already provide, and the package
|
|
# that supplies each one.
|
|
my %PACKAGE_FOR = (
|
|
dhclient => 'isc-dhcp-client',
|
|
ifenslave => 'ifenslave',
|
|
hwclock => 'util-linux-extra',
|
|
);
|
|
|
|
my %mandatory = map { $_ => 1 } mandatory_commands($module);
|
|
my @packages = required_packages($builder);
|
|
|
|
for my $command (sort keys %PACKAGE_FOR) {
|
|
ok($mandatory{$command}, "the Ubuntu dracut module installs '$command' unconditionally");
|
|
ok(scalar(grep { $_ eq $PACKAGE_FOR{$command} } @packages),
|
|
"the build root installs $PACKAGE_FOR{$command}, which provides '$command'");
|
|
}
|
|
|
|
# doxcat asks dhclient for the provisioning lease.
|
|
ok($mandatory{dhclient} && scalar(grep { $_ eq 'isc-dhcp-client' } @packages),
|
|
'the Genesis image can obtain a DHCP lease');
|
|
|
|
# dracut_install is silent about a missing command, so the payload needs its own gate.
|
|
# xCAT-genesis-base.spec runs the same verifier on the EL path.
|
|
my $text = do { open my $fh, '<', $builder or die "$builder: $!"; local $/; <$fh> };
|
|
like($text, qr{verify-genesis-payload}, 'builddeb-genesis-base verifies the payload it packages');
|
|
|
|
# An absolute path in the install() output is a data file, not a command.
|
|
sub mandatory_commands {
|
|
my ($path) = @_;
|
|
my $dir = tempdir(CLEANUP => 1);
|
|
my $driver = "$dir/collect.sh";
|
|
open my $fh, '>', $driver or die "$driver: $!";
|
|
print $fh <<"BASH";
|
|
dracut_install() { printf '%s\\n' "\$\@"; }
|
|
instmods() { :; }
|
|
inst_multiple() { :; }
|
|
inst() { :; }
|
|
dpkg-architecture() { echo x86_64-linux-gnu; }
|
|
. '$path'
|
|
# _dracut_install_opt installs only what the build root already has. Neutralise it after
|
|
# sourcing, so its commands stay out of the mandatory set.
|
|
_dracut_install_opt() { :; }
|
|
install
|
|
BASH
|
|
close $fh;
|
|
my @out = qx{bash '$driver' 2>/dev/null};
|
|
die("running install() from $path produced nothing") unless @out;
|
|
my %seen;
|
|
my @names = grep { !$seen{$_}++ } grep { length && !m{^/} } map { chomp; $_ } @out;
|
|
die("install() from $path named no bare commands") unless @names;
|
|
return @names;
|
|
}
|
|
|
|
# Evaluate the assignment rather than parse it, so the list is the value the script uses.
|
|
sub required_packages {
|
|
my ($path) = @_;
|
|
my $text = do { open my $fh, '<', $path or die "$path: $!"; local $/; <$fh> };
|
|
my ($block) = $text =~ /^(REQUIRED_PACKAGES="[^"]*")/ms;
|
|
die("no REQUIRED_PACKAGES assignment in $path") unless $block;
|
|
my $out = qx{bash -c 'set -u; $block; printf "%s\\n" \$REQUIRED_PACKAGES' 2>/dev/null};
|
|
my @packages = grep { length } split /\s+/, ($out // '');
|
|
die("REQUIRED_PACKAGES in $path evaluated to nothing") unless @packages;
|
|
return @packages;
|
|
}
|