mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-21 16:39:30 +00:00
Daniel Hilst
35e4ac2d3a
reg_linux_diskless_installation_flat fails on an EL 10 riscv64 compute node after the node has provisioned correctly. The check that fails is "vmothersetting contains machine", and lsdef shows the attribute empty. The case corrupts the KVM machine type, checks that the node does not boot, and restores it. The restore reads str3 from a ladder that names ppc64 and x86_64 only, so on riscv64 str3 is empty and chdef writes an empty vmothersetting. The remove path later compares str1 against that same empty str3, which bash reports as "unary operator expected". Both ladders gain a riscv64 arm giving machine:virt, the machine a riscv64 guest runs and the one guest_arch_profile in kvm.pm sets. The two comparisons now quote their operands, so an empty value compares instead of ending the command. diskless_flat_vmothersetting_machine.t fails five of fifteen assertions without this change. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
See unit/README.md and bats/README.md for the detailed rules for
each unit-test suite.