Daniel Hilst
926c076533
mock_build_owner reads chrootuid and chrootgid from the text of the rendered configuration. It does not see a value set in an included file, an assignment with an inline comment or a double-quoted key, or an include that overrides an earlier assignment. prepare_mock_resultdirs then gives the result directories to the wrong uid, or to none. prepare_mock_resultdirs changes only the two directories. A root build that stopped part way leaves root-owned 0644 logs in them, and mock, running as uid 1000, cannot append to them on the next run. native/mock_resultdir_owner.t runs mock's loader on each configuration case, and checks as root that uid 1000 can append to the stale logs in both directories. Ubuntu ships no mock, so the workflow runs it in a Fedora container and fails when it skips. The unit test checks, with chown recorded, which owner the directories and their files get. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test
Unit tests that run from the source checkout are split by implementation language:
| Test type | Location | Runner |
|---|---|---|
| Perl unit tests | xCAT-test/unit/*.t |
prove -r xCAT-test/unit |
| Shell unit tests | xCAT-test/bats/*.bats |
bats -r xCAT-test/bats |
| Black-box service tests | xCAT-test/blackboxtest/ |
python3 -m unittest discover -s tests, then blackboxtest run <conf> on a management node |
| Native host tests | xCAT-test/native/*.t |
Explicit lab runs; see native/README.md |
| CLI functional tests | xCAT-test/autotest/testcase/ and xCAT-test/autotest/bundle/ |
xcattest -f <cluster.conf> -t <case> or xcattest -f <cluster.conf> -b <bundle> |
Use Perl .t tests for Perl modules, Perl scripts, templates, and repository
artifacts. Use BATS tests for shell-script behavior that can be exercised from
the checkout by sourcing a shell library or script and shadowing external
commands.
Shell behavior should not be tested by Perl tests that grep shell source. Put
those tests under xCAT-test/bats instead.
blackboxtest is the odd one out: its Python unit tests and blackboxtest validate run offline like the others, but its point is the third column --
asking a management node what a booting node asks (DHCP, DNS, TFTP, HTTP,
xcatd) and asserting on the answers. It talks to the services only as a client,
so it does not depend on which DHCP server answers or on the xCAT database.
See unit/README.md, bats/README.md and blackboxtest/README.md for the
detailed rules for each suite.