mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-21 08:33:20 +00:00
Daniel Hilst
b91795a8f4
Thirteen test files this branch adds call BAIL_OUT at fifty-one places: an extraction that stopped matching, a fixture that is not there, a harness that wrote no log. prove stops every remaining file on a bail-out, not only the file that called it, so one of them hides the results of every test that would have run after it. die is just as loud and costs only its own file. Fifteen comments the branch added also carried the incident rather than the constraint. Three pasted an error transcript, five traced a failure from a macro or a missing file out to a node that never boots, and the rest counted call sites, package sizes or dracut build numbers. Each now states the one fact the reader cannot re-derive from the code. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
47 lines
1.7 KiB
Perl
47 lines
1.7 KiB
Perl
#!/usr/bin/env perl
|
|
# The genesis specs name their package after the target arch: xCAT-genesis-scripts-<tarch> and
|
|
# xCAT-genesis-base-<tarch>. %{tarch} comes from an %ifarch ladder, and an arch missing from that
|
|
# ladder leaves the macro unexpanded instead of failing, so rpm builds a package whose Name
|
|
# carries the macro.
|
|
#
|
|
# Expand each spec with rpmspec for every arch xCAT supports and assert the Name carries that arch.
|
|
use strict;
|
|
use warnings;
|
|
|
|
use FindBin;
|
|
use Test::More;
|
|
|
|
my $root = "$FindBin::Bin/../..";
|
|
|
|
sub command_exists { my ($c) = @_; return system("command -v $c >/dev/null 2>&1") == 0 }
|
|
|
|
plan skip_all => 'rpmspec is not installed' unless command_exists('rpmspec');
|
|
|
|
# arch under test => the tarch the spec must resolve it to (x86 and ppc64 are historical names
|
|
# genesis keeps; see genesis_tarch_from_targetarch in buildrpms.pl).
|
|
my %tarch = (
|
|
x86_64 => 'x86_64',
|
|
i686 => 'x86',
|
|
ppc64le => 'ppc64',
|
|
aarch64 => 'aarch64',
|
|
riscv64 => 'riscv64',
|
|
);
|
|
|
|
my %spec = (
|
|
'xCAT-genesis-scripts' => "$root/xCAT-genesis-scripts/xCAT-genesis-scripts.spec",
|
|
'xCAT-genesis-base' => "$root/xCAT-genesis-builder/xCAT-genesis-base.spec",
|
|
);
|
|
|
|
for my $pkg (sort keys %spec) {
|
|
my $spec = $spec{$pkg};
|
|
ok(-f $spec, "$pkg spec is present") or next;
|
|
for my $arch (sort keys %tarch) {
|
|
my $name = `rpmspec --target $arch -q --qf '%{NAME}' --define 'version 2.19.0' --define 'release snap0' @{[quotemeta $spec]} 2>/dev/null`;
|
|
chomp $name;
|
|
is($name, "$pkg-$tarch{$arch}", "$pkg on $arch is named $pkg-$tarch{$arch}");
|
|
unlike($name, qr/%\{/, "$pkg on $arch leaves no unexpanded macro in its name");
|
|
}
|
|
}
|
|
|
|
done_testing();
|