mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-05 04:27:55 +00:00
Daniel Hilst
2a5463659b
On a netplan-rendered node the reconfigure path takes the interface down unconditionally, while the `netplan apply` that brings it back is gated on reboot_nic_bool. In the diskful provision postscripts stage reboot_nic_bool is 0, so configeth downs the NIC and nothing brings it back until the node reboots -- over the very interface the postscripts are talking on. The other two arms pair their halves: the ifupdown arm answers `ifdown` with an unconditional `ifup`, and the redhat arm gates both the down and the up. Only the netplan arm takes one half. Nothing in the suite covers it. This drives the two blocks configeth actually executes -- the down-selection inside the modify branch and the restart block underneath it -- with `ip`, `ifdown`, `ifup` and `netplan` shadowed by shell functions, which bash resolves ahead of $PATH, so every call is recorded rather than run and the host's network is never touched. Six of the eight assertions pass already and are there to pin the arms that are correct: redhat gating both halves, ifupdown pairing its own, and the reboot_nic_bool=1 path doing the down before the apply. The two that fail are the bug. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>