An IPv6-only provisioning network cannot deploy a node. The discovery and
credential callbacks open IPv4 sockets, the kickstart and boot templates
render an IPv4 address into every endpoint, and makehosts drops an IPv6
value because hosts.pm gates on isIpv4addr.
NetworkUtils gains the address helpers the rest of the change uses:
format_host_port, parse_host_port and format_uri_host bracket an IPv6
literal, getNodeNetworkCfg6 reads the static IPv6 configuration of a node,
my_ip_facing_family selects the management-node address of one family,
getIPv6ReverseZone builds a nibble-aligned reverse zone, and
node_is_ipv6_only and ipv6_server_for_node answer the two questions the
plugins used to answer for themselves. credentials.pm opens the callback
socket through IO::Socket::INET6 when the modules are present and keeps the
IPv4 path when they are not. Template.pm and anaconda.pm render an IPv6
kickstart network line and bracketed endpoints. The postscripts and the
stateless xcatroot format every endpoint through the bracketing helpers.
xCAT-server requires perl-IO-Socket-INET6 and perl-Socket6 on EL, and
libio-socket-inet6-perl and libsocket6-perl on Debian.
(cherry picked from commits c0a69bb5a and caa8ca790)
Ported onto upstream master ee6b4f532. The two commits are folded because the
second refactors the first. Master is kept where it has a newer form of the
same thing: the getipaddr cache guard, the Kea control_socket_path helper, the
netboot method list, install_device_params, the modern_installer test and the
isValidIp validator, which replaces the isValidIPAddress this branch added.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT-test/integration
Integration tests. These run against an installed management node -- they need a
real xCAT installation, and depending on the test a populated /install, a service
binary they can execute, or a live daemon.
The Perl tests are driven by xcattest through the testcase in
../autotest/testcase/integration/, which proves the copy installed by the
xcat-test package:
prove -I/opt/xcat/lib/perl -I/opt/xcat/lib/perl/xCAT \
-r /opt/xcat/share/xcat/tools/autotest/integration
Run the case by hand on an MN with:
xcattest -f <cluster.conf> -t integration_tests
The case carries the ci_test label, so it also runs on every pull request: the
xcat_test GitHub Actions workflow installs and configures xCAT on the runner, which
makes that runner a (single node) management node, and then runs every ci_test case
against it.
Note the -I flags: unlike the unit tests these run from the installed location, so
they pick up xCAT modules from /opt/xcat/lib/perl rather than from a source tree.
The case checks rc==0 and output=~Files=10,. The file count checks that prove
found all ten files, which catches a packaging regression or a test renamed away from
.t without updating the count. It does not prove that environment-gated cases ran;
inspect the TAP output for skips. Add to that number when you add a test. A missing
directory is already caught by rc==0 -- prove -r on a path that does not exist exits
2.
Note also that github_action_xcat_test.pl invokes each case through sudo, so in CI
these tests run as root while the unit tests run unprivileged. That is the right
way round -- integration tests legitimately need to write to places like /etc/kea,
whereas running the unit tests as root would let permission-related assertions pass
for the wrong reason.
What belongs here
A test belongs in integration/ when it needs something the checkout cannot provide:
| Test | Requires |
|---|---|
copycds_packages_integrity.t |
/install populated by a real copycds |
dhcp_isc_config_validation.t |
a dhcpd binary that can read the generated config, as root |
dhcp_isc_ipxe_leases.t |
dhcpd and omshell, root, and ip netns for a private network namespace |
dhcp_ipxe_dispatch.t |
dhcpd with omshell, or kea-dhcp4, root, and ip netns for two private network namespaces |
dhcp_kea_config_validation.t |
a kea-dhcp4 binary that can read the generated config |
dhcp_kea_control_agent_smoke.t |
live kea-dhcp4 and kea-ctrl-agent, root, and the Kea host-commands hook |
html_form_runtime_dependency.t |
the installed HTML::Form module |
openeuler_package_postscripts.t |
Linux root, private mount namespaces and DNF; tests complete package postscripts with command doubles and an isolated repository directory |
openeuler_postscript_repositories.t |
Linux root, private mount namespaces, DNF and RPM signing tools; tests actual signed repository transactions in isolated install roots |
wsapi_apache_access.t |
an Apache binary and its modules; reads xcat-ws.conf from the source tree, so github_action_xcat_test.pl runs it from the checkout and the installed copy skips |
xcatd_dispatch_redaction.sh |
a live xcatd, syslog delivery to /var/log/xcat/cluster.log, and root |
Run xcattest -t xcatd_dispatch_redaction to check password redaction in the
daemon's syslog output. This separate case has the ci_test label. It enables
site.xcatdebugmode, creates a temporary node, and restores the setting and removes
the node on exit. Run it without concurrent changes to site.xcatdebugmode.
Environment guards
openeuler_postscript_repositories.t builds and signs RPM fixtures and runs real
DNF transactions. Enable it explicitly on a disposable openEuler host:
sudo env XCAT_NATIVE_REPOSITORIES=1 prove -v \
xCAT-test/integration/openeuler_postscript_repositories.t
The Perl test builds the RPM fixtures directly. Its DNF adapter records arguments and uses only local fixture repositories, with a fixed fixture release version.
Tests with optional runtime dependencies guard with plan skip_all -- an MN with no
Kea installed should skip the Kea tests, not go red. The HTML::Form test is different:
it verifies a required installed dependency and fails when that module is absent. A
skip in this directory is therefore expected and normal.
Which tests actually run consequently varies by node. On a GitHub runner, for example,
/install is empty so copycds_packages_integrity.t skips, while
dhcp_kea_config_validation.t does run because the case executes as root and can
therefore validate from /etc/kea.
dhcp_kea_control_agent_smoke.t is opt-in on top of that:
plan skip_all => 'set XCAT_KEA_LIVE_SMOKE=1 to run live Kea daemon smoke test'
unless $ENV{XCAT_KEA_LIVE_SMOKE};
It starts real Kea daemons, so it stays off unless asked for. Do not enable it on a node whose DHCP service is in use.
What does not belong here
Anything that only needs the checkout. Those go in ../unit and
run on every pull request, which is much faster feedback than waiting for a cluster
test.