mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-04 20:17:55 +00:00
Daniel Hilst
1cebb4d9e8
ubuntu_resolvconf_ip.t sandboxes the fragment by rewriting /etc/resolv.conf to a path inside a tempdir. The fragment contains `rm -f /etc/resolv.conf` and the unit suite runs as root in CI, so if that substitution ever stops matching the test deletes the runner's resolver configuration instead of failing. It matches today. It is one respelling away from not: writing the path in the template as `etcdir=/etc; rm -f "$etcdir/resolv.conf"` slips straight past it, and the existing BAIL_OUT does not catch that -- it guards only the fragment extraction, not the rewrite. Check the rewritten script for any /etc path outside the scratch tree and BAIL_OUT rather than execute it. AGENTS.md asks that a test never escape its scratch tree and notes that rewriting paths in the source under test is the fragile way to arrange it; this makes the fragile part fail closed. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>