mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-11-19 00:42:29 +00:00
04a1d6865a
firmware_features returned no feature for a node whose vm.othersettings says firmware:efi, so the domain stated nothing about Secure Boot. libvirt then runs firmware autoselection and takes the descriptor of highest priority that fits the guest. The descriptors are ordered by file name, and the first x86_64 one of an EL 10 host is 30-edk2-ovmf-x64-sb-enrolled.json, so the node starts with Secure Boot on and with keys enrolled. The firmware then refuses the unsigned kernel the node netboots. The same node boots on a host whose first descriptor is 50-edk2-ovmf-x64-nosb.json, because the order is host policy. firmware_features now returns the secure-boot feature disabled for a UEFI guest that does not ask for Secure Boot, which is the requirement libvirt filters the descriptors by. It says nothing about enrolled-keys, which only a firmware with secure-boot reads. A guest with no firmware still asks for no feature, because libvirt refuses a <firmware> feature where no firmware autoselection runs. kvm_secureboot_firmware.t covers both, and its four new checks fail without this change. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>