mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-11-19 17:02:15 +00:00
8e9c1e2ab1
mysqlsetup commented the bind-address line by writing the result to /tmp/my.cnf and renaming it over the configuration file. A file created in /tmp takes user_tmp_t, and a rename keeps the type of the file it moves, so the management node was left with a MySQL configuration that mysqld is denied read of. The denial survives the command and was seen in three rounds of the SELinux campaign. The temporary path is also a fixed name in a world writable directory, written as root. comment_bind_address now reads the file, substitutes the line and writes the result back through the same file. Truncating in place keeps the inode, which is what carries the label, so no relabel is needed afterwards. The candidate list moves to @BIND_FILES and the resolution order does not change: the Ubuntu mariadb.conf.d file, then /etc/mysql/my.cnf, then /etc/my.cnf. mysqlsetup_bind_address_label.t drives the sub against a scratch tree and asserts the inode survives, that only a line starting with bind is commented, and that no temporary file is left beside the target. With the rewrite put back through a renamed file in /tmp, the inode check is the one check of the thirteen that fails. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>