mirror of
https://github.com/xcat2/xcat-core.git
synced 2026-09-05 12:37:54 +00:00
Daniel Hilst
0925e2b599
Hoisting the systemd-timesyncd stop/disable above the ntpd hand-off moved it inside the window makentp_ntp_deps.t extracts as $select, and that harness stubbed only logger and check_executes. So the extracted region called the real systemctl -- and the unit suite runs as root in CI. Probed with a recording systemctl first on PATH, `prove makentp_ntp_deps.t` made 12 real invocations, stop and disable for each of the six selection cases; on the Ubuntu review MN a stand-in timesyncd unit went from enabled/active to disabled/inactive while the suite reported PASS. That is the "never let a test escape its scratch tree" rule, and it failed silently: the assertions passed either way, so nothing said the host had been changed. Shadow every command the region can reach, not only the ones it reached when this was written -- the region moves. Bash resolves functions ahead of $PATH, so these win without touching PATH. The stubs use echo rather than printf '...': the harness runs `bash -c '...'`, so a single quote inside the prelude closes that string early. The existing logger stub gets away with it; three more did not, and the ntpd selection cases failed until they were rewritten. Verified after: zero real systemctl invocations from the whole unit suite under the same probe, and 18/18 still pass. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>