xCAT/xcat-core
2
0
Fork 0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-09-11 20:16:25 +00:00
Code Issues Releases Wiki Activity
28,050 Commits 21 Branches 82 Tags
fc73cd91f1623bde35ab2e2d9ea65cf8c2eae7a4
Commit Graph

69 Commits

Author SHA1 Message Date
Vinícius Ferrão d5f882291d fix(nodestat): accept the fping option that the usage message gives 
The manual page and the usage message of nodestat give the option
-f|--usefping. The preprocessor of the request knows no option f, and the
handler of the request spells the long name useping, so --usefping does
nothing. An administrator who follows the manual page gets the nmap path, and
gets no message that says why.

The two places also read different specifications, so an option that one
place accepts can reach the other place and take a different meaning. Put the
specification in one routine, and let both places read that routine.

Give the name usefping to the option, and keep useping as a second name. That
spelling has worked since 2.14.2, so a site can have it in a script.

The long name of the fping option starts with the same letters as usemon, so
--use and --us become names that Getopt::Long cannot decide. Those two
abbreviations select usemon today. Keep them with usemon, or an administrator
who monitors with them loses the monitoring and gets no message.

The change has two other effects. The abbreviations --use and --us no longer
select fping as well, which they did only because the two places read
different specifications. The bundles -mf and -fm now select both options,
which they did not do before.

Recovered from the lenovobuild branch.
 2026-08-23 22:38:41 -03:00
Vinícius Ferrão 10945e7fee fix(nodestat): report a clear error when fping is missing 
nodestat -f runs fping to reach the nodes; if the fping package is not
installed the pipe yielded no output and nodestat silently returned an empty
result. Check that an fping binary exists before running it and emit an
explicit "must install fping" error otherwise.

Recovered from the unmerged lenovobuild branch (original f0c88182), reworked
to test for the binary directly: the original inferred fping's presence from
whether the pipe produced output, which false-positived (reporting fping
missing) when fping was present but every node was unresolvable -- caught in
lab validation.

Co-authored-by: Jarrod Johnson <10814490+jjohnson42@users.noreply.github.com>
 2026-07-25 21:41:07 -03:00
Mark Gurevich 3ecf73ce6b Fix 'quiet' spelling 2022-11-29 11:50:18 -05:00
Bin Xu 40d74ace1b Adding port 22 for unprivileged node ping (#4324) (#5699) 2018-10-12 17:01:37 +08:00
GONG Jie 859a72caee Remove trailing spaces in file xCAT-server/lib/xcat/plugins/nodestat.pm 2017-12-31 23:59:59 +00:00
robin2008 671231833d modify nodestat usage and manpage for -f|--useping 2018-05-31 17:13:04 +08:00
Victor Hu 3f03d53e8b Initialized more_options variable to avoid uninitialized error message 2017-04-25 16:51:24 -04:00
immarvin e944e7fd22 fix issue xcat command returns 0 when cmd fails due authorization #2636 2017-03-13 23:08:39 -04:00
Mark Gurevich 0a3fbd8d51 perltidy all perl files 2016-07-20 11:40:27 -04:00
linggao 82c90e2227 null node appstatus when status is noping for nodestat -u. 2015-04-21 16:51:59 -04:00
jjohnson2 fb02c18853 Fix erroneous 'noping' in various circumstances 
nmap's raw IP facility is prone to mistakes in various
environments.  Disable the raw IP handling by
telling nmap to run as if it didn't have privilege
 2015-03-20 10:58:26 -04:00
linggao 73d08b58fa added nmapoptions in the site table to resolve network slow response issues in nmap. defect 4300 2014-10-22 18:36:59 -04:00
jbjohnso dabd5d5f09 Certain nmap output with ipv6 could leave nodename with a trailing \n, correct 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@15251 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2013-02-25 16:26:08 +00:00
immarvin 4b2677b87e replace "XCATBYPASS=Y xdsh..." with "InstUtils->xcmd()" 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@14894 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2013-01-16 08:22:01 +00:00
lissav 7adbe1de86 fix defect 2985 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@14786 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2013-01-07 18:54:00 +00:00
ligc 7469e7dc83 fix two perl syntax errors in nodestat.pm: Use of uninitialized value 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@14270 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2012-11-08 02:19:31 +00:00
jbjohnso 83ea798bcd Fix problem where nodestat with hosts table lookup fails 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@14235 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2012-11-04 17:25:32 +00:00
jbjohnso 16f9d196ca nmap ipv6 support can be pretty easily messed up, change probe parameters from default '80' 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@13961 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2012-10-08 21:08:03 +00:00
jbjohnso d5064385f8 Fix problem where nodestat would make two ipv4 passes 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@13482 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2012-08-10 16:23:23 +00:00
zhaoertao 40e144b4cc for item: clean up Utils.pm, the code in xCAT-server/lib/xcat/plugin/ 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@13467 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2012-08-09 04:07:40 +00:00
jbjohnso 07b89a8df3 Hve nodestat also look for https server 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@13458 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2012-08-08 20:59:29 +00:00
jbjohnso 1d4db3c080 Fix nmap to never attempt reverse lookup 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@13457 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2012-08-08 20:56:47 +00:00
jbjohnso 9f8d68ed3d Have nodestat support IPv6 destinations 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@13184 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2012-06-27 13:35:55 +00:00
jbjohnso f590db8fc4 Have nodestat fallback to hosts.ip lookup if applicable 
Make nodestat more IPv6 workable with nmap

git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@13163 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2012-06-25 19:41:33 +00:00
jjhua dab53851c9 For the places that open site table to read attributes, change to call xCAT::Utils->get_site_attribute instead 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@12887 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2012-05-23 05:17:42 +00:00
jbjohnso 60f1f2ed5f Fix nodestat reliability issue 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@12118 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2012-04-04 17:43:24 +00:00
linggao 5c047d1073 fixed a bug for nodestatus 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@11519 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2012-02-08 18:37:48 +00:00
linggao e92cdf5792 fixed a bug for nodestatus 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@11515 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2012-02-08 16:28:48 +00:00
datajerk cd13afb3d5 Added MS RCP and RDP to detect installed node. 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@10498 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2011-09-12 17:37:27 +00:00
jbjohnso 6f81d9b68a Fix nodestat without arguments 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@10057 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2011-07-12 12:57:32 +00:00
jbjohnso 89743f5fbc Provide user way to specify manual use of fping to allow workaround for RHEL 6.0 bug 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@9981 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2011-06-29 12:03:28 +00:00
jbjohnso eb1ecfbc5b -Prevent attempting query of xCAT install monitor script if the node is not in install state 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@9660 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2011-05-23 18:32:29 +00:00
ellen56 ee9ee54e5b fix defect 3152286 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@9030 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2011-03-11 07:04:37 +00:00
linggao 9d69302916 added support to run command on the mn against all the nodes for nodestat command. 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@7976 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2010-10-29 18:18:03 +00:00
linggao c0aa4c2a24 bug fix, extra line like XXXXXYYYYYZZZ was printed out for noping nodes 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@7826 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2010-10-12 20:44:45 +00:00
jbjohnso 5b63531ff4 -Fix previous checkin 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@7600 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2010-09-23 18:34:17 +00:00
jbjohnso 28161c99f2 -Fix for rhel6 nodestat/pping 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@7598 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2010-09-23 18:15:48 +00:00
jbjohnso 2238966cda -Fix nodestat for routed nodes using nmap 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@7033 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2010-08-10 18:57:30 +00:00
ligc 7293793c1a ipv6 fix, replace the Socket library calls with NetworkUtils subroutines 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@6042 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2010-05-10 09:04:59 +00:00
linggao 99bea5bc1f added option for getting power status for nodestat comand 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@5530 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2010-03-19 14:57:57 +00:00
linggao 56e62e91a0 minor fix 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@5491 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2010-03-16 20:42:12 +00:00
linggao 6a2947a492 minor, removed a debug message 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@5487 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2010-03-16 20:33:32 +00:00
linggao 0f2075d595 support getting power sttaus for nodes that are noping in nodestat command 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@5486 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2010-03-16 20:29:56 +00:00
linggao 523f862d06 add time stamps for nodelist.status and nodelist.appstatus 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@5433 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2010-03-10 19:09:30 +00:00
linggao 1cae57f314 added default ll and gpfs port number in nodestat.pm 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@5119 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2010-02-02 18:35:28 +00:00
linggao 1a19bf0389 added searching for port number in /etc/services for applications that do not have port number specified in monsetting table for appstatus monitoring 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@5118 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2010-02-02 17:58:28 +00:00
linggao aa68229e33 change status string from 'active' to 'ping' in nodestat command 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@5117 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2010-02-02 16:31:05 +00:00
linggao bde3e92d14 minor fix 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@5102 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2010-02-01 16:51:43 +00:00
linggao ee1eec6f95 appstatus support, xcatmon updates appstatus, nodestat command supporting updating the db 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@5100 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2010-02-01 16:18:49 +00:00
jbjohnso d2b03ac4f4 -Tolerate mismatch between forward and reverse lookups 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@4957 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
 2010-01-15 19:31:26 +00:00