2
0
mirror of https://github.com/xcat2/xcat-core.git synced 2026-11-19 17:02:15 +00:00
Commit Graph

2 Commits

Author SHA1 Message Date
Daniel Hilst edea395c29 test(packaging): the IPv6 module dependency is asserted for the wrong families
The assertions added with this test required Socket6 and IO::Socket::INET6 on every
RPM family, which contradicts xcat_server_inet6_optional_dependency.t and the reason
it records: every call site loads the modules with an eval and keeps working on IPv4,
so a hard dependency states a dependency the code does not have.

The measurement that prompted the test still holds, and it is narrower than it looked.
Both modules are absent on a Leap 15.6 management node because the openSUSE Minimal-VM
image sets solver.onlyRequires = true in /etc/zypp/zypp.conf, so zypper installs no
recommended package. dnf installs one, so EL and openEuler need no hard dependency.

The test now reads requires and recommends separately per family: openSUSE requires
both and recommends neither, EL and openEuler recommend both and require neither. The
deb control files are read per package, since perl-xCAT has carried a hard dependency
since before this rule. xcat_server_inet6_optional_dependency.t gains a pointer to the
openSUSE exception so the two files do not disagree in prose.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-29 09:05:15 -03:00
Daniel Hilst 7703372cc2 test(packaging): nothing declares the two Perl modules every IPv6 path needs
xCAT::SLP, xCAT::IPMI, xCAT::Client, xCAT::NetworkUtils and the dhcp, nodestat and
credentials plugins reach IPv6 only through Socket6 and IO::Socket::INET6. Each one
loads them with eval { require ... }, so a missing module is not an error. The guard
variable stays false and the IPv6 branch is never taken.

No family declares the dependency. perl-generators reads a use statement, not a
require inside an eval, so the EL build derives no perl(Socket6) either, and
xCAT-server lists the two deb packages as Recommends, which apt 3.0 solver3 can drop.

The test asserts both specs require both modules on openSUSE, EL and openEuler, and
that both deb control files name them in Depends.

Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
2026-10-29 08:52:19 -03:00