SLOF, the open firmware of a PowerKVM guest and a PowerVM LPAR, identifies
itself with an RFC 3315 DUID-LL built from the MAC of its interface, and it
reports no UUID at all. makedhcp derives every DHCPv6 reservation from
vpd.uuid, so the reservation of a ppc64le node can never match: measured on an
IPv6-only node, SLOF sent 00:03:00:01:<mac> against the 00:04:<uuid>
reservation xCAT wrote. The node gets no reserved address and no RFC 5970
option 59, and its firmware has nothing to load.
dhcp6_client_duid now takes the MAC and the architecture. kea_duid_ll_from_mac
builds the DUID-LL from the first address of mac.mac, which is the interface
that netboots, and dhcp6_firmware_duid_is_link_layer says which architectures
send one. A ppc64le node takes the DUID-LL with no attribute set, and the
byte-order warning about vpd.uuid is not reported for it, because that firmware
does not read the value. mac.duid gains ll, which selects the DUID-LL on any
architecture. firmware and canonical are unchanged and still override.
One reservation covers the whole netboot: the grub2 ieee1275 network stack
builds its DUID from the same interface, so the loader sends what the firmware
sent. That is why no second reservation is written, unlike a chainloading UEFI
node.
dhcp_dhcpv6_duid.t gains five cases. On the unfixed tree 15 of its 195
assertions fail, cn11 with the firmware-order DUID-UUID where the DUID-LL is
expected. A mutation that gives every architecture the DUID-LL fails 42,
naming the x86_64 cases that must keep the DUID-UUID.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
On an IPv6-only x86_64 node with netboot=ipxe the firmware fetches the shim and
starts iPXE, and iPXE then prints "Nothing to boot: No such file or directory".
The node falls through to "BdsDxe: No bootable option or device was found". The
same node boots over IPv4.
A UEFI node that chainloads is two DHCPv6 clients on one NIC and they send
different DUIDs. EDK2 copies the SMBIOS UUID into its DUID-UUID in the order
SMBIOS stores it, little-endian in the first three fields from SMBIOS 2.6 on,
and iPXE converts the same bytes to RFC 4122 order first. Measured on
xcat147-cn-tmp-333 with vpd.uuid 5d2df358-d529-11f1-9757-4233c0a89316: the
firmware sends 00:04:58:f3:2d:5d:29:d5:... and iPXE sends
00:04:5d:2d:f3:58:d5:29:... kea_node_reservations6 and addnode6 write one
reservation, keyed on the DUID that mac.duid selects, so the other client
matches nothing and gets no RFC 5970 option 59. On IPv4 the reservation is
keyed on the MAC and both clients share it.
dhcp6_client_duid_list now returns every DUID the clients of a node send, and
both backends reserve for each of them when the netboot method chainloads. The
first entry keeps the address and the hostname: Kea refuses a second
reservation for one address, and _reservation_matches treats a shared hostname
as the same reservation. dhcp6_bootfile_url_for_node takes the client, because
iPXE needs the boot script of the node and not the shim again, which is the
split the DHCPv4 client classes make with the iPXE feature options.
A MAC-keyed reservation was measured and rejected. Kea 2.4.1 derived no MAC for
these clients even with mac-sources ipv6-link-local and the EUI-64 link-local
on the wire: the lease kept an empty hwaddr column and the firmware took a pool
address. ISC DHCP has no hardware-address match for DHCPv6 at all. Two
reservations for one address are refused with "There's already reservation for
this address/prefix", and one reservation cannot hold both identifiers:
"the 'hw-address' and 'duid' are mutually exclusive".
xCAT-test/unit/dhcp_dhcpv6_duid.t covers both backends. Seven of its cases fail
without this change.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
yaboot links its configuration file to one name for each address of the node in
the mac table. The name is sprintf("%02x%02x%02x%02x", split(/\./, $ip)), and an
IPv6 address has no four octets: sprintf reads the first field as a number and
fills the rest with zeroes, so 2001:db8:156::10 gives 7d1000000. A dual-stack
node got one correct link and one link to a name no firmware requests, with no
warning. getipaddr returns the IPv6 address first on such a node, so this is
reachable without an IPv6-only network.
yaboot_config_name returns a name only for an address with four octets in range,
and the loop passes over anything else. A node that produced no name at all is
reported with what to use instead, rather than reporting success.
The error for a node with no facing address and no service node interpolated
$myname, which is declared in the branch above it and not in that one. The file
has no "use strict", so the message read ": " and the name of the management node
was lost. It now determines the name where it uses it.
This commit no longer routes the facing address by family. yaboot is reachable
only at osarch=ppc64 with RHEL earlier than 7 or SLES earlier than 11.4, and the
support matrix carries no ppc64 column, so there is no supported configuration
whose yaboot node could be IPv6-only. petitboot keeps that work, because
nodediscover selects it for PowerNV and noderes.5 documents it for bare-metal
ppc64le.
yaboot_config_name.t covers the guard. Removing it fails the four name checks and
leaves the two IPv4 checks passing, which tells the defect apart from a test that
dies.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
Integration test of the 51 commits that landed on upstream master after this
branch was built. Four conflicts, all from edits to the same lines:
perl-XCAT/xCAT/BootUtils.pm: both sides add a new sub at the end of the file.
Master adds expand_node_template, this branch adds grub2_kernel_commands and
grub2_image_provides. All three are kept.
xCAT/xCAT.spec and xCATsn/xCATsn.spec: master wraps the chrony and dhcpd
requirements in a suse_version test, and its %endif lands on the line this
branch uses for radvd. The requirement stays outside the test, because an
openSUSE management node writes radvd.conf too.
xCAT-server/xCAT-server.spec: master's openSUSE requirement list is a superset
of this branch's, so master's is taken whole.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
The Subiquity templates build three URLs as
"http://#XCATVAR:XCATMASTER##COLONHTTPPORT#/install/autoinst/...", and that tag
renders the bare value of the master. For an IPv6-only node that is a literal
address, so wget read the last group as a port:
wget -T 30 -O /tmp/getinstdisk http://2001:db8:147::1/install/autoinst/getinstdiskhttp://2001:db8:147::1/install/autoinst/getinstdisk: Bad port number.
The early-commands script runs under "set -eux", so that one line ended it.
subiquity reported CalledProcessError from Early/run, wrote a crash report of
kind "unknown", and stopped before curtin ran. Nothing in the installer logs
named the cause: curtin-install.log was empty, cloud-init was healthy, and the
error report that looked like the failure was the Error CONTROLLER loading its
own configuration.
Template.pm already computed $master_uri_host, bracketed for an IPv6-only
node, and used it for the SLES media URL and the repo baseurl. It is now
exposed as #MASTERURIHOST#, and the three URLs take it.
#XCATVAR:XCATMASTER# keeps the bare value where it is right: bash reads
/dev/tcp/<host>/<port> with no brackets, and the updateflag notification uses
that form.
subiquity_uri_host.t reads both templates, which are the artifact: every
http:// URL has to take the URI host, the /dev/tcp line has to keep the bare
one, and Template.pm has to substitute the tag. Restoring the bare tag in one
URL fails two checks; dropping the substitution fails the third.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
Both Subiquity templates wrote "dhcp4: true" for every node, in the network
section the installer uses and in the netplan the late command writes into the
installed system. An IPv6-only node has no DHCPv4 server to answer, so netplan
brought the provisioning NIC up with no address.
Measured on an IPv6-only node: the installer fetched its autoinstall seed over
IPv6, then could not configure the interface and fell back to asking at the
console. On a serial console that waits for a keypress, so the install stopped
at the mode prompt with no sign of why. The installed system would have had no
address either, which is the defect xcatroot had for a diskless node and
cd6719946 fixed there.
#SUBIQUITYDHCP:<indent># and #SUBIQUITYTARGETDHCP# render from the address
family of the node, beside the #SUBIQUITYINSTALLNIC# and #SUBIQUITYINSTALLMAC#
tags that were already there. An IPv6-only node gets dhcp6 with dhcp4 turned
off explicitly, because netplan defaults dhcp4 to false only when nothing
names it, and the overrides follow the family in use. An IPv4 node gets what
it had, byte for byte.
$node_ipv6_only becomes 'our' so a test can set it. subvars already computes
it before these substitutions run, so nothing recomputes the lookup.
subiquity_ipv6_netplan.t covers both families and both sites, and asserts the
templates carry the tags rather than a literal. ubuntu_subiquity_installnic.t
renders the new tag and gains an IPv6 case: it runs the late command for real,
and an unrendered tag is a shell comment that swallows the redirect, so that
test would have written no file at all.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
subiquity_url_kcmdline left ip= out of the command line, on the reasoning that
casper treats an absent IPv4 half as already done. It does, and it also skips
the whole networking stage: casper calls configure_networking only inside
if [ -n "${STATICIP}" -a "${STATICIP}" != "frommedia" ]
and STATICIP comes from ip=. With no ip= the interface was never brought up,
so wget answered "Cannot assign requested address" and casper panicked with
"Unable to find a live file system on the network". The URL, the brackets and
the served ISO were all correct; nothing had an address to reach them from.
ip=off takes that branch while asking for no IPv4: configure_networking reads
ip= into IP and treats off as already done, then runs dhcpcd -6 on ip6=dhcp.
Measured on an IPv6-only node. With ip=off the console shows dhcpcd-10.0.6,
then "Trying to download and mount http://[2001:db8:147::1]:80/.../install.iso",
and the management node's access log records
2001:db8:147::1003 "GET /install/ubuntu24.04.4/x86_64/install.iso" 200 3405470119 "Wget"
the whole 3.2G ISO over IPv6, after which subiquity starts. Without ip=off the
same node fails at the wget every time.
debian_subiquity_boot_params.t asserts ip= is present. Removing it from the
command line fails that check alone.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
configure_router_advertisements took the mgtifname of every IPv6 network in
the networks table. site.dhcpinterfaces names the interfaces this server
answers on, and the advertisement ignored it, so a management node restricted
to eth1 still advertised itself on eth0. Every client on that LAN can then
select it as a router, which is what restricting the interface was meant to
prevent.
The sub now takes the interface set the DHCP configuration was built from and
skips a network whose interface is not in it. All three call sites already had
the set: the ISC path in scope, and both Kea paths as a parameter. An empty or
absent set is no restriction, so a cluster that sets no dhcpinterfaces keeps
the behaviour it had.
There are also two fixes to how radvd is started:
- The service is examined on every call rather than only when the
configuration file changed. A start that failed left the file already
correct, so every later makedhcp returned on the file alone and never tried
again while radvd stayed down. The call also moved out of the dhcpd6 restart
branch of the ISC path, which a repeat makedhcp does not enter at all.
- restartservice answers -1 when the service is not installed and the exit
status of the command otherwise. Only the -1 was reported, so a radvd that
failed to start was silent. Every nonzero result is now reported, and the
message says which of the two it was.
dhcp_dhcpv6_duid.t drives the sub directly for the service cases, because
process_request reaches it only on some paths. Dropping the interface filter
fails the check on an unserved network; restoring the early return on an
unchanged file fails the restart check and leaves the one for a service that
is already up passing; ignoring a positive exit status fails the two checks
that name it.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
mknetboot read networks.gateway and passed it to dracut_static_ip6 as it
stood. '<xcatmaster>' is the common value of that column, and it reached the
kernel command line as "[<xcatmaster>]", which is not an address. A node whose
image server sits off its own link then had no route to it.
static_ip6_boot_arg resolves the gateway through ipv6_server_for_node, which
already knew the placeholder and which the AutoYaST path already used. A
gateway that does not resolve is dropped rather than written as a bad address:
an address with no route still reaches a server on the same link.
The composition is its own sub, taking its two lookups as coderefs, because
the helpers were covered while nothing connected them to the call site.
debian_static_ip6_gateway.t drives it with the real dracut_static_ip6.
Passing the gateway unresolved puts "[<xcatmaster>]" in the argument, which
two of its checks report.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
link_install_iso unlinked its destination and then created the link. copycds
can be given the ISO that is already in the install tree, or the link that a
previous run left there, and the destination is then the same file as the
source. The unlink deleted it, and the symlink that followed pointed at a path
that no longer existed. An ISO copied into /install by hand was lost, and the
tree was left with a dangling link that answers 404 to the node fetching it.
The source and the destination are now compared by device and inode before
anything is removed, which also follows the link, so a second copycds of the
same media leaves the link alone instead of recreating it.
debian_subiquity_boot_params.t covers an ISO at the destination, a link that
resolves to the media, and a different ISO that replaces the link. Without the
comparison the first case leaves a dangling link and the file is gone, which
three of the new checks report.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
_autoyast_network6 replaced '<xcatmaster>' in site.nameservers with the
gateway of the node, and fell back to the gateway when the list held no IPv6
address. '<xcatmaster>' is the management node, which runs named. The gateway
is not: a cluster whose gateway is a separate router gave every node a
resolver that answers nothing, and a cluster with no gateway gave none at all,
so the installed node resolved no hostname.
The placeholder now resolves through ipv6_server_for_node, which is what the
gateway itself already used. A value that is not an address is not written,
so an unresolvable placeholder leaves the list empty rather than putting
"<xcatmaster>" in the profile.
autoyast_ipv6_network.t gains a management node that is nobody's gateway, so
the two can be told apart, and the check that asserted the old behaviour now
asserts the new one. Restoring the gateway fails five checks and leaves the
other nineteen passing.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
An IPv6-only node could not install Ubuntu. subiquity_boot_params refused it,
because casper mounts the live filesystem with klibc nfsmount, which has no
IPv6: it answers "need a path" for "[2001:db8::1]:/export" and for
"2001:db8::1:/export", while an IPv4 server gets past parsing to the mount.
casper takes nfsroot= as an opaque path, so no option changes the family.
casper has a second route. do_urlmount downloads an ISO with casper's own
wget, which speaks IPv6, and loop-mounts it, and the network itself was never
the limit: init parses ip6= and configure_networking runs "dhcpcd -1KL -6" on
it. The route needs an ISO to fetch, and xCAT serves the extracted media and
kept no ISO.
copycds now passes the ISO it was given to the distribution plugin, which
links it into the install tree as install.iso. A symbolic link, because the
Ubuntu 24.04 ISO is 3.2G, and the xcat.conf xCAT ships gives /install
"Options FollowSymLinks". A block device has no path to link and passes none.
An IPv6-only node then gets "ip6=dhcp boot=casper netboot=url
url=http://[server]:port/install/<os>/<arch>/install.iso", with no nfsroot
and no toram: do_urlmount already holds the ISO in the initramfs tmpfs, so
copying the live filesystem again only doubles the memory the node needs.
That memory is the cost of the route -- 3.2G for the ISO on top of the
installer -- so a node with 4G cannot take it.
An IPv4 node is untouched and still mounts its root over NFS. A tree copied
before this change carries no ISO, so such a node is refused as before, with
a message naming install.iso and copycds.
debian_subiquity_boot_params.t goes from 17 checks to 36. Routing an IPv6-only
node back to the NFS form fails the six HTTP checks; dropping the bracketing
fails exactly the two bracketing checks; and returning success from
link_install_iso without creating the link fails the three that read the link
back, while the one that reads the return value still passes.
Not yet booted on a cluster.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
subiquity_boot_params refuses an IPv6-only node and says the live installer
"configures its network and mounts its root with klibc, which has no IPv6
support". The first half is wrong. casper reads ip6= from the kernel command
line and configures the interface with dhcpcd -6, which speaks DHCPv6:
scripts/functions runs "dhcpcd -1KL -t $ROUNDTTT -6" on the ip6= value, and
init parses ip6= at line 156. klibc ipconfig is only the IPv4 branch.
The one component with no IPv6 is klibc nfsmount, which casper uses for the
live filesystem. Measured on noble klibc-utils 2.0.13: it answers "need a
path" for "[2001:db8::1]:/export" and for "2001:db8::1:/export", while an
IPv4 server gets past parsing to the mount, and the binary carries no inet6
string against seven nfs and mount strings.
The refusal stands, because casper takes nfsroot= as an opaque path and has
no way to pass it an address family. Only its reason changes. The comment
also records the route that would close this: netboot=url fetches an ISO with
casper's own wget, which does IPv6, and that is a different provisioning
method than the extracted tree xCAT exports.
The check on the message matched /klibc/, which is the family and not the
component, so it passed for any klibc tool. It now matches /nfsmount/, and
the previous wording fails it.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
yaboot links its configuration file to one name for each address of the node
in the mac table. The name is sprintf("%02x%02x%02x%02x", split(/\./, $ip)),
and an IPv6 address has no four octets: sprintf reads the first field as a
number and fills the rest with zeroes, so 2001:db8:156::10 gives 7d1000000.
A dual-stack node therefore got one correct link and one link to a name no
firmware requests, with no warning. An IPv6-only node got only the second.
yaboot_config_name returns a name only for an address with four octets in
range, and the loop passes over anything else. A node that produced no name
at all is reported with what to use instead, rather than reporting success.
The facing address was found with my_ip_facing, which resolves with inet_aton
and reports an IPv6-only node unresolvable. yaboot_facing_address asks
node_address_family first, the way grub2.pm and petitboot.pm do, and the
!myipfn! substitution goes through substitute_facing_address so a placeholder
that a port follows is bracketed.
The error for a node with no facing address and no service node interpolated
$myname, which is declared in the branch above it and not in that one. The
file has no "use strict", so the message read ": " and the name of the
management node was lost. It now determines the name where it uses it.
yaboot_ipv6.t covers both subs. Restoring the unguarded sprintf fails the
four name checks; calling my_ip_facing unconditionally fails the three family
checks. The IPv4 checks pass under both, which is what tells the two defects
apart from a test that dies.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
petitboot asks for a configuration file named after the four octets of the
IPv4 address of the node, in hexadecimal. The name is built with
sprintf("%02x%02x%02x%02x", split(/\./, $ip)), and an IPv6 address has no
four octets: sprintf reads the first field as a number and fills the rest
with zeroes, so 2001:db8:156::10 gives 7D1000000. nodeset then links the
configuration to a name no firmware requests, reports success, and the node
boots nothing.
petitboot_config_name returns the name only for an address that has four
octets in range, and nodeset reports the node instead of linking a name that
cannot work. The message says what to use: an IPv4 address on the node, or
netboot=grub2, which carries the server in the boot file URL and needs no
name of this form.
This is a refusal, not support. What name petitboot asks for over DHCPv6 is
not established here, and no cell in the lab runs petitboot, so the value
cannot be measured. An error that names the limit is what an operator can
act on; a wrong name is not.
Five checks in petitboot_ipv6.t cover it. Restoring the unguarded sprintf
fails the three IPv6 and undef checks and leaves the two IPv4 checks passing,
including the name of 192.0.2.50, which stays C0000232.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
petitboot builds the URL it fetches a kernel and an initrd from as
"$httpmethod://$installsrv:$httpport$tftpdir/", so an IPv6 install server
gives "http://2001:db8::1:80/tftpboot/...", which cannot be split into a host
and a port. The node then has no server to fetch from.
The facing address is found with my_ip_facing, which resolves with inet_aton.
An IPv6-only node is reported unresolvable, and the node gets no
configuration at all.
petitboot_boot_url builds the URL through uri_authority, which brackets an
IPv6 address. petitboot_facing_address asks the family of the node which
helper answers, the way grub2.pm does. The three !myipfn! substitutions go
through substitute_facing_address, which brackets the placeholder that a port
follows and leaves every other one bare. petitboot.pm also now loads
xCAT::NetworkUtils, which it has always used and never named.
An IPv4 node keeps the URL it had, byte for byte, including the port that the
old form always wrote.
petitboot_ipv6.t covers both. Writing "$server:$port" back in place of
uri_authority fails the two IPv6 URL checks. Calling my_ip_facing
unconditionally fails the three family checks. Neither mutation touches the
IPv4 checks, which is what separates the two defects from a test that dies.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
configure_router_advertisements writes /etc/radvd.conf and runs sysctl on the
management interface. dhcp_dhcpv6_duid.t drives makedhcp through
process_request, so the test reaches both. The suite runs as root in the
GitHub CI, where the test therefore replaces the real /etc/radvd.conf of the
runner and turns IPv6 forwarding on for its interfaces.
Where the file is not writable the warning also reaches the callback that
other checks read, so the test failed on an unprivileged host:
Structures begin differing at:
$got->[2] = 'Cannot write /etc/radvd.conf, so the IPv6 networks
announce no route: Permission denied'
$expected->[2] = Does not exist
The path is now the package variable $radvdconffile, and the sysctl call is
the sub enable_ipv6_forwarding. The test localizes both, the way it already
localizes $dhcpconffile and xCAT::Utils::restartservice.
Six checks now cover the behaviour the configuration carries: the file is
written, it names the interface of the IPv6 network, the interface sends
advertisements, the managed flag is on, the prefix is announced, and
forwarding is enabled. Removing the call from the ISC path fails exactly
those six and leaves the other 127 passing.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
kea_process_request has two paths. The full regeneration writes the whole
configuration, restarts the services, unlocks and returns; the incremental one
falls through to the end. The call added in the previous commit sat only on the
incremental path, so makedhcp -n, which is what configures a new cluster, wrote
no /etc/radvd.conf at all.
Measured on an IPv6-only alma10.1 management node: with radvd.conf removed,
radvd stopped and forwarding set to 0, makedhcp -n left all three unchanged.
The generator itself was correct the whole time; it was never called.
The full regeneration now configures the advertisements before it returns.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
makedhcp writes the DHCPv6 reservations and nothing announces the network. xCAT
configures no router advertisement anywhere: a fresh IPv6 provision network has
no radvd and forwarding off.
Two failures follow from that one gap. A client that follows RFC 4861 uses
DHCPv6 only when an advertisement sets the managed flag, so iPXE reported
"No configuration methods succeeded" and never sent a solicit: the DHCPv6 log
held the firmware DUID alone. And a client that does solicit gets one address
with a prefix length of 128, because the on-link prefix and the default route
come from the advertisement, not from DHCPv6.
makedhcp now writes /etc/radvd.conf for every IPv6 network in the networks
table and restarts radvd, for both the ISC and the Kea backend. The
advertisement sets the managed flag and marks the prefix on-link but not
autonomous, so the address still comes from DHCPv6, which holds the
reservations. An IPv4 cluster gets no file and no service. A management node
without radvd gets a warning naming what the nodes lose.
Measured on an IPv6-only alma10.1 node with netboot=ipxe. Without the
advertisement iPXE stopped at "No configuration methods succeeded". With it
iPXE reported "Configuring (net0 ...) ok" and
"net0: 2001:db8:149::1002/64 gw fe80::4054:ff:fec9:95d3", loaded the kernel,
and the node booted and answered ssh, xdsh and updatenode over IPv6.
Captured by xCAT-test/unit/radvd_config.t. Removing the managed flag fails the
assertion that names it; making the prefix autonomous fails the assertion that
names that.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
The commit that added ipxe to the DHCPv6 gate justified it with strings found
in snponly.efi. That was not evidence that the feature is built in, and a boot
disproved it.
Measured on an IPv6-only alma10.1 node with ipxe-xcat 2.0.0: the firmware does
fetch the shim over IPv6 from the option this code sends, the shim chains to
snponly.efi, and iPXE then reports "No configuration methods succeeded" on a
network whose only DHCP server is DHCPv6. iPXE never reaches the script.
The option stays, because it is what xCAT owes a client that asks, and the node
fails at the same point without it. The comment now records what the loader
cannot do, so the next reader does not repeat the strings test.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
The previous commit replaced !myipfn! with the facing address, which fixed the
kernel command line. It left the eleven other places where setstate writes
${next-server} into the script directly, among them the imgfetch lines for the
kernel and the initial ramdisk. An IPv6 node resolved those to
"http:///tftpboot/..." and had no server to fetch its kernel from.
Measured on an IPv6-only alma10.1 node: the script carried
"http://[2001:db8:149::1]:80/install/..." for the command line and
"http://${next-server}/tftpboot/.../vmlinuz" for the kernel.
The server is now computed once in setstate and used at every site, so the
whole script names one server. An IPv4 node still gets ${next-server}, which
iPXE fills from its own offer.
netboot_ipxe_method.t and secureboot_ipxe_node_shim.t load xnba.pm against a
stub of xCAT::NetworkUtils. The stub gains the two methods setstate now calls,
and both tests describe their nodes as IPv4, which keeps ${next-server}.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xnba.pm writes ${next-server} in place of !myipfn! and lets iPXE fill it from
the DHCP offer. next-server is a DHCPv4 field, so an IPv6 node resolves it to
the empty string and every URL in the script loses its host. The fallback does
not help either: my_ip_facing resolves with inet_aton, so it reports an
IPv6-only node unresolvable.
The script now carries the facing address of the management node when the node
has an IPv6 address, bracketed because the script puts it in a URL. The lookup
names the family, the way grub2.pm does. An IPv4 node keeps ${next-server}, so
nothing changes for it.
ipxe.pm runs this code with SCRIPTS and METHOD set to its own, so the change
reaches netboot=ipxe as well as netboot=xnba.
xnba.pm also calls xCAT::NetworkUtils eight times without loading it, and works
only because another module does. The use is now explicit.
Captured by xCAT-test/unit/ipxe_script_server.t. Ignoring the family fails five
of its seven assertions and leaves the two IPv4 ones passing.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
dhcp6_bootfile_url_for_node writes RFC 5970 option 59 for grub2 alone, so a node
with netboot=ipxe takes its reserved IPv6 address and has nothing to load. Its
firmware then releases the address and solicits again. grub2 was the only
loader an IPv6 node could use.
The iPXE build xCAT ships does speak DHCPv6: snponly.efi, the UEFI loader of
ipxe-xcat 2.0.0, carries dhcpv6, ipv6 and four IPv6 strings, against a control
of 26 iPXE and dhcp strings in the same binary. The firmware that solicits over
DHCPv6 is UEFI, so the UEFI loader is the only one such a client can ask for.
An ipxe node now gets tftp://<bracketed server>/<UEFI loader>, and the loader
name comes from BootPolicy->x86_loader, which is the one place it is chosen. No
URL is written when that file is not on disk, because naming a file the TFTP
server does not have costs the client a timeout it cannot diagnose; the Kea
client classes already refuse it for the same reason.
xnba keeps its exclusion. Its loader reports one ipv6 string against a control
of five, where the iPXE loader reports five against 26, so there is no evidence
it reads option 59.
Captured by xCAT-test/unit/dhcp_dhcpv6_duid.t. Removing ipxe from the gate fails
the first assertion; removing the on-disk check fails the second.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
mknetboot gave an IPv6-only node ip=either6, which asks dracut for DHCPv6.
DHCPv6 assigns one address with a prefix length of 128 and carries no route, and
an xCAT provision network sends no router advertisement: radvd is not installed
and net.ipv6.conf.<nic>.forwarding is 0. The node came up with the address and
no way to reach the server, and the dracut hook reported
"Connecting to [2001:db8:147::1]:80... failed: Network is unreachable."
debian.pm now builds the static form from the address, gateway and prefix the
node already has in the database, the way sles.pm passes hostip and gateway to
linuxrc. either6 remains the answer when the address cannot be resolved.
Captured by xCAT-test/unit/dracut_static_ip6.t. Removing the prefix length from
the parameter fails four of its nine assertions and leaves the bracketing and
the refusal cases passing.
Measured on an IPv6-only Ubuntu 24.04 node: Kea records prefix_len=128 for its
lease, and dracut logged BOUND6 for eth0 before the fetch failed.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
grub2_kernel_commands read the image and not the architecture, so a ppc node
whose grub2 image carries linuxefi was given it. linuxefi loads an EFI binary
and a ppc loader is not one. The previous commit removed the architecture test
along with the defect it carried.
The command now needs both: the architecture whose loader is an EFI binary, and
an image that carries the command.
grub2_netboot_protocol.t covers the three architectures and caught this. Its
loader fixture now records the commands it carries, because the configuration
follows the image.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
setstate in grub2.pm appends "efi" to the kernel and initrd commands for every
node whose architecture matches x86, so the configuration reads linuxefi and
initrdefi. Both come from a downstream patch. grub2-xcat 2.12-2 for Ubuntu is
built from upstream grub and carries neither, so the node loads the loader and
its own configuration over TFTP, prints "can't find command `linuxefi'", asks
for no kernel, and waits at the menu until it is powered off.
The pair now comes from the image served to the node. BootUtils reads the
image, which records the name of every command its modules register, and
answers linuxefi and initrdefi only when the image carries them. An image that
cannot be read is answered with linux and initrd, which every grub2 image
carries.
This reaches a node only when it netboots with grub2. An IPv6 node has no other
loader, because bootfile-url is written for grub2 alone.
Measured on an IPv6-only Ubuntu 24.04 node: with linuxefi the node made no TFTP
request for the kernel; with linux it loaded the kernel and the initial ramdisk
and printed no error.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
With nodeauthentication off and no peer name, getpostscript used
_xcat_authname as the client identity and expanded it with noderange.
becomeuser and tokens set _xcat_authname to an account name, so a user
named after a node group received the postscripts of the first node in
that group.
xcatd now records the CN of the validated client certificate as
_xcat_certname, and only while no becomeuser or token replaced it. It
deletes any _xcat_certname the client sent. getpostscript uses that
name only when it names exactly one node, with no group or range
expansion. _xcat_authname is no longer a candidate.
getpostscript_client_identity.t drives the plugin with these requests.
On the previous head the group and node login checks fail, and
dropping the exact match fails the group and range checks.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
The search list added in the previous commit carried no config:type, and the
AutoYaST schema gives searchlist the LIST type, the way it gives it to
nameservers. xmllint against profile.rng of Leap 15.6 reports only "Element
profile failed to validate content", and YaST refuses the profile entirely, so
the node cannot install at all.
searchlist is now emitted as a typed list. Measured against
/usr/share/YaST2/schema/autoyast/rng/profile.rng on a live management node: the
generated profile fails to validate, the same profile with the attribute added
validates, and removing hostname as well changes nothing, so hostname was not
the element at fault.
Captured by xCAT-test/unit/autoyast_ipv6_network.t, which gained an assertion on
the attribute.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
_autoyast_network6 sets dhcp_hostname to false, because an IPv6-only node has no
DHCPv4 to take a hostname from, and it writes no hostname of its own. YaST then
has nothing to set: y2log of an installed node records Y2Network::Hostname with
@static=nil, @transient=nil and @dhcp_hostname=:none, and the node answers
"localhost". The two sibling builders in the same file write both keys.
The dns section now carries the node name and a search list of the node domain.
getNodeNetworkCfg6 already returns the name, so no new lookup is needed.
Captured by xCAT-test/unit/autoyast_ipv6_network.t. Without the two keys its
assertions 17 and 18 fail and the other 16 pass.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
_autoyast_network6 passed the node nameserver list through unchanged, so an IPv6-only
node was configured with the IPv4 resolver that site.nameservers names for the cluster.
The node cannot reach it, and an unreachable server in resolv.conf costs every lookup
a timeout.
The list now keeps only the IPv6 servers. When that leaves none, the gateway stands
in, which is the management node and already answers for the node. The <xcatmaster>
substitution is unchanged.
Captured by xCAT-test/unit/autoyast_ipv6_network.t, where two of its sixteen
assertions fail without this change.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
An IPv6-only openSUSE node completed its install with the static IPv6 address in its
AutoYaST profile, then booted with a link-local address only. The applied profile on
the node carried bootproto static and the address, and ifcfg-eth0 read BOOTPROTO=dhcp
with a modification time later than the install.
post.sles.common writes that file. It keeps the interface configuration only when
MANAGEDADDRESSMODE reads static, and managed_address_mode returned
site.managedaddressmode, which was unset. xCAT wrote the static configuration and then
removed it.
managed_address_mode now takes the node and reports static for a node that
xCAT::NetworkUtils::node_is_ipv6_only reports as IPv6-only. A node with any IPv4
address keeps the site value, so an IPv4 and a dual-stack cluster are unchanged.
Captured by xCAT-test/unit/template_ipv6_rendering.t, where one of the three new
assertions fails without this change.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
The Ubuntu diskless kernel command line carries no dracut ip= parameter. dracut then
configures the interface it needs with DHCPv4, so an IPv6-only node comes up with no
global address, cannot fetch imgurl and never mounts a root.
gen_net_boot_params now returns ip6 beside the ip it already derived, spelled either6,
which asks dracut for DHCPv6 and falls back to router advertisement. debian.pm appends
it for a node that xCAT::NetworkUtils::node_is_ipv6_only reports as IPv6-only, so an
IPv4 node is told exactly what it was told before. The ip the EL path reads is
unchanged.
Captured by xCAT-test/unit/networkutils_dracut_ipv6_boot_param.t. This closes the
derivation; the Ubuntu diskless path is not yet proven end to end on a cluster.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
_autoyast_network6 builds a networking section with a static interface, but did
not set keep_install_network. AutoYaST then keeps the network the installer
used and ignores the interface in the profile.
The node installed over IPv6 and booted with ifcfg-eth0 BOOTPROTO=dhcp and no
address but a link-local one. xcat.sh could not reach the management node:
"logger: failed to connect to 2001:db8:156::1 port syslog-conn" and
"connect: Network is unreachable", so no postscript ran and the node never
registered.
The section now sets keep_install_network to false, which is what makes AutoYaST
write the static interface.
Measured on the installed node: /etc/sysconfig/network/ifcfg-eth0 carried
BOOTPROTO=dhcp and the only address was fe80::4078:c0ff:fea8:9c0a.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
_autoyast_network6 emitted dhcp_resolv in the dns block of the networking
section. The AutoYaST schema of Leap 15.6 does not accept that element, and one
element it refuses invalidates the whole profile: YaST reported "Extra element
networking in interleave", then "A profile for this machine could not be found
or retrieved", and the installation stopped.
dhcp_resolv says whether DHCP may overwrite resolv.conf. The section configures
the node statically, so there is no DHCP to keep away from resolv.conf.
Measured with the schema the installer ships, /usr/share/YaST2/schema/autoyast/
rng/profile.rng: the profile failed to validate at the networking element, and
removing dhcp_resolv alone made it validate.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
sles.pm gave linuxrc no network arguments beyond the net device. linuxrc
configures IPv4 by default, so an IPv6-only node sent an IPv4 DHCPDISCOVER,
received "no/incomplete answer", and reported "Failed to download AutoYaST
file" without ever contacting the install source.
static_ipv6_boot_args() adds ipv6only=1 with the address, prefix, gateway and
IPv6 nameserver of the node. The node is configured statically for the reason
anaconda.pm configures EL statically: the firmware answers DHCPv6 with the
RFC 6355 DUID-UUID that the reservation is keyed on, while the installer builds
a DUID of its own that matches no reservation.
Measured on a Leap 15.6 node: with these arguments the installer fetched
control.xml from http://[2001:db8:156::1]:80/install/leap15.6/x86_64/1 from its
own address 2001:db8:156::10. Without ipv6only=1 linuxrc ignores the rest and
stays on IPv4.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
addnet6 read the dynamic range from $netcfgs{$net}, where $net is the subnet it
writes, "2001:db8:156::/64". addrangedetection stores the range under
networks.net, "2001:db8:156::", so the lookup always missed and makedhcp warned
"No dynamic range specified" for a network whose row declares one.
The subnet then carried no range6, and a DHCPv6 client whose DUID matches no
reservation received no address. The SUSE installer is such a client: linuxrc
builds its own DUID rather than the DUID-UUID the firmware sends, so it could
not get an address even though the node has a reservation for the same MAC.
dynamic_range_for() looks the range up under the subnet as written and then
under the network address alone.
xCAT-test/unit/dhcp_dhcpv6_conf_file.t fails its prefix-form assertion when the
second lookup is removed.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
The media_url of an autoyast add-on product came from
"#TABLE:noderes:$NODE:nfsserver#", which substitutes the address of the
management node without brackets. An IPv6-only node therefore received
<media_url>http://2001:db8::1//install/leap15.6/x86_64</media_url>, and YaST
cannot read that as a URL, so the installer reached no repository.
_sles_media_url() uses the bracketed master host for a node with no IPv4 address
and keeps the substitution for every other node, which service nodes rely on.
xCAT-test/unit/template_ipv6_rendering.t fails its two IPv6 assertions when the
bracketed host is dropped.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
grub2.pm replaced !myipfn! with the facing address as it stands. sles.pm and
anaconda.pm put that placeholder where a URI authority expects a host, with the
port already appended, so an IPv6-only node was told to install from
"http://2001:db8:156::1:80/install/...". Nothing can split that into an address
and a port, so the installer could not reach the repository.
substitute_facing_address() brackets a placeholder that a port follows and
leaves every other one bare, because xcatd=!myipfn! names a host with no port
and the postscripts read that value as it stands.
The other five plugins that substitute the placeholder serve BIOS PXE, ppc64le
and yaboot, none of which network boots over IPv6, so they keep the bare
replacement.
grub2_ipv6.t and sles_install_url_ipv6.t fail their bracketing assertions when
the port-aware branch is removed, and their bare-address assertions still pass.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
sles.pm built its install URLs as "$server:$port". An IPv6 address contains
colons, so a node was told to install from
"http://2001:db8:156::1:80/install/leap15.6/x86_64/1" and could not reach the
repository. The same join was in the statelite and stateless imgurl=. The XCAT=
argument beside them was already bracketed.
rootimg_url() and autoyast_boot_args() now build those URLs through
xCAT::NetworkUtils::uri_authority(), which brackets an IPv6 address and passes a
name or a !myipfn! placeholder through unchanged. uri_authority is the former
xcatd_cmdline_address, renamed because three URL sites now share it;
xcatd_cmdline_address stays as a wrapper for its own callers.
xCAT-test/unit/sles_install_url_ipv6.t fails its four IPv6 assertions when the
colon join is restored.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
ISC serves DHCPv4 and DHCPv6 from two files in the same directory. dhcp.pm set
the v6 file inside the branch that switches the v4 file to /etc/dhcp/dhcpd.conf.
openSUSE already has /etc/dhcpd.conf, so the branch never ran, $dhcp6conffile
stayed undef, and makedhcp wrote no IPv6 configuration. dhcpd6 then exited with
"No subnet6 declaration for eth1" and no node could get an IPv6 lease.
dhcp6_conf_file_for() now returns the v6 file that belongs beside a given v4
file, and the module derives it after every branch that chooses the v4 file.
xCAT-test/unit/dhcp_dhcpv6_conf_file.t fails on the openSUSE and /etc/dhcp3
layouts when the derivation is restricted to /etc/dhcp again.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
With a boot configuration written, an IPv6-only node reached the live installer and
could only PXE-loop. casper configures the interface with klibc ipconfig and mounts
the root with klibc nfsmount, and neither knows IPv6: measured on noble, the
ipconfig in the casper initrd carries no IPv6 string at all, and nfsmount answers
"need a path" for both "[2001:db8::1]:/export" and "2001:db8::1:/export".
subiquity_boot_params now refuses a node with no IPv4 address and says why. The
caller already reports the message and skips the node. A node with an IPv4 address
is unaffected.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
nodeset refused the node and named the wrong reason:
Error: The <node> can not be resolved
Error: Failed to generate grub2 configurations for some node(s)
The node resolves: it has an IPv6 address and no IPv4 one. setstate resolved the
!myipfn! placeholder with my_ip_facing, which resolves its argument with inet_aton
and so reports any IPv6-only node unresolvable.
The lookup now follows the address family of the node, as the tftpserver lookup in
the same file already does. A node with an IPv4 address keeps the lookup it had.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
vm.othersettings firmware: accepted only efi, which leaves Secure Boot to libvirt
firmware autoselection. Autoselection picks a descriptor by host policy, so on a
host whose best match enrolls keys the guest refuses an unsigned boot loader:
NBP file downloaded successfully.
BdsDxe: failed to load Boot0004 "UEFI PXEv6" : Access Denied
That decides whether a node can network boot over IPv6. A DHCPv6 bootfile-url is
written for a grub2 node alone, and the grub2 image under /tftpboot/boot/grub2 is
built with grub2-mkimage and is not signed, so a node with Secure Boot enforced
cannot start it and falls through to the next boot entry.
firmware: now also takes efi-secureboot and efi-insecure, and build_xmldesc adds
the <firmware> element that states the request. enrolled-keys follows secure-boot
because libvirt refuses a guest whose keys are enrolled while Secure Boot is off.
XML::Simple writes the firmware attribute of <os> and the element has the same
name, so the element is added to the rendered XML rather than to the hash.
firmware:efi keeps its behaviour and adds no element.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
makedhcp wrote no boot file into a DHCPv6 reservation, so the firmware took the
reserved address and had nothing to load. EDK2 reported "PXE-E21: Remote boot
cancelled" and tried the next boot entry, which reads as a DHCP failure although
the address was granted. Measured on openEuler 24.03: dhcpd6.conf carried no
bootfile reference where the DHCPv4 configuration carried fifteen.
addnode6 now emits option dhcp6.bootfile-url, which is RFC 5970 option 59, from
the same helpers the Kea backend uses. Those two helpers read noderes and
BootPolicy, not Kea, so they lose their kea_ prefix.
Two further defects kept the same node from booting. The DHCPv6 daemon was never
started: ISC runs it as a second service, the flag that recorded the need was
assigned and never read, restart_dhcpd restarted only the DHCPv4 service, and the
service map had no ISC DHCPv6 name. And makedhcp failed with "The file
/etc/sysconfig/dhcpd6 doesn't exist" although no EL or openEuler dhcp package
ships that file and dhcpd6 does not need it: with the file deleted the daemon
still binds the provisioning NIC, because ISC dhcpd listens only on the
interfaces its subnet declarations name.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
sles.pm matched ipv6 nowhere in 2801 lines and the SUSE templates wrote
"<bootproto>dhcp</bootproto>" directly, so an IPv6-only SUSE node had no way to configure its
installer: DHCP cannot serve it, and SUSE has no static handoff on the kernel command line.
_autoyast_network6 builds the networking section of such a node, with a static interface, the
address of the node and a prefix length, which is what AutoYaST takes for IPv6 instead of a
netmask, and a default route carrying the IPv6 gateway.
The #YAST2NET6# directive chooses between that and the DHCP block the templates carried. An IPv4
node gets that block unchanged, which is why the existing #YAST2NET# was not used: its DHCP arm
renders something else, and leap15.6 is a gating cell. compute.leap15.tmpl and compute.sle15.tmpl
take the directive.
autoyast_ipv6_network.t covers the section. Emitting a netmask instead of a prefix length fails 2
of its 11 assertions. The IPv4 output of the directive was compared with the text it replaced and
is identical.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
root=nfs:, XCAT=, xcatd= and imgurl=http:// all separate the server from what follows with a
colon, so an IPv6 address in any of them cannot be told from the path or the port. Eight sites
built those values by interpolation, and a diskless, statelite or cloned node of any family took
a command line its initrd could not parse.
build_statelite_nfsroot_parameter brackets the server, which covers the NFS root of all three
netboot plugins at once. debian.pm and sles.pm now build the XCAT endpoint and the image URL
through xcatd_cmdline_address and format_host_port, as anaconda.pm already did for the install
path, and the mksysclone endpoint of anaconda.pm and sles.pm goes the same way.
destiny.pm had a third xcatd= site. The earlier change covered the two genesis branches and left
the legacy nbk branch interpolating the address.
nfs_root_options.t asserts the bracketed form, the IPv4 form and the mount options after a
bracketed address. Removing the brackets fails 2 of its 80 assertions and leaves the IPv4 and the
name cases passing.
zvm.pm carries the same pattern and is left alone: z/VM has no IPv6 netboot path to test it on.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
makedhcp builds a DUID-UUID from vpd.uuid and the reservation carries one identifier, but no
network manager derives that identifier in the byte order the firmware sends. NetworkManager has
no option for the SMBIOS UUID at all, and systemd-networkd's DUIDType=uuid uses the decoded
product UUID, which is the other order. So a node whose installed OS speaks DHCPv6 matched no
reservation and took a pool address.
configdhcpv6duid writes the identifier for whichever renderer the node has: the whole DUID for
NetworkManager, and the type by name with the sixteen bytes alone for systemd-networkd, which
composes the two. It is in the default postscript list for Linux, after remoteshell. AIX has
neither renderer and keeps its list.
A diskless or statelite node needs nothing: its address comes from the kernel command line and
configeth writes dhcp6: false, so its image sends no DHCPv6 request.
postscript_dhcpv6_duid.bats pins both forms to the literal the two Genesis images already use,
so the four copies of the byte swap cannot drift apart, and asserts the node fails loudly when
it has no renderer. postscript_dhcpv6_duid_registered.t holds the registration down: dropping it
fails 3 of its 7 assertions.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
mknetboot excluded a statelite node from the static IPv6 address with no reason recorded, and
mksysclone had no IPv6 code at all. Both reach the same dracut networking as a diskless node, so
both asked DHCPv6 with the identifier their initrd generates. A reservation matches one
identifier, so the node took a pool address and no boot URL.
Statelite now takes the same path as diskless, and mksysclone renders the address beside the
Genesis kernel it boots.
anaconda_ipv6_statelite_sysclone.t drives both commands against a SQLite fixture. Restoring the
statelite guard fails one of its six assertions and removing the mksysclone block fails another,
while the diskless assertion survives both, so the gate did not move for diskless.
debian.pm records why the Ubuntu live filesystem is mounted over IPv4. The comment blamed casper,
which passes nfsroot= through untouched; klibc nfsmount is what cannot read an IPv6 server.
Measured on noble: "[2001:db8::1]:/export" and "2001:db8::1:/export" both answer "need a path",
while "192.0.2.1:/export" is accepted.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>