%posttrans relabels /install and nothing else, so a path under /opt/xcat
whose label was wrong before an upgrade stays wrong: rpm does not relabel a
directory that already exists. Measured on xcat163-mn-tmp-286, where
/opt/xcat/probe/subcmds/bin kept usr_t through the upgrade that fixed its
packaging, and only took bin_t once rpm created it.
xcat_selinux_package.t now asserts that %posttrans relabels /opt/xcat as
well. 1 of its 75 checks fails on this commit.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
/opt/xcat/probe/subcmds/bin is created by the %post of xCAT-probe, so no
package owns it. A directory a scriptlet creates takes the context of its
parent, usr_t, and not the bin_t that the policy gives /opt/.*/bin, and
nothing relabels it afterwards. Measured on xcat163-mn-tmp-286:
restorecon -n -v -R /opt/xcat
Would relabel /opt/xcat/probe/subcmds/bin from
unconfined_u:object_r:usr_t:s0 to unconfined_u:object_r:bin_t:s0
It is the only path under /opt/xcat whose label does not match the policy.
The directory is in use: xcatprobe:263 drops a switchprobe symlink in it,
and xCAT-probe/debian/dirs already packages it on Debian.
xcat_probe_package_payload.t asserts that %install creates it, that %post
does not, and that the Debian package keeps it. 2 of its 4 checks fail on
this commit.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
The policy granted xcat_t everything the image build needs, so the domain
that listens on the xcatd port could also write and relabel a file of any
type. The rules were one per target type, 558 of them from the measured
denials, and 85 per cent of those repeated one of 58 permission patterns.
xcat.te now carries two domains. xcat_image_t is entered through
/opt/xcat/bin/genimage and the per-OS genimage program, from xcat_t and
from the administrator, and it holds the filesystem-wide manage and relabel
grants: the build creates an operating system tree, and the kernel cannot
tell a path inside that tree from the same type on the management node.
xcat_t keeps the daemon surface -- its sockets and ports, /install,
/tftpboot, /etc, the credentials, the service class for the units it
restarts -- and no grant over the file_type attribute.
The rules are Reference Policy interface calls where one exists:
domain_read_all_domains_state replaces 93 of them, dev_getattr_all_chr_files
31, files_read_etc_files, auth_read_shadow, seutil_read_config,
logging_send_syslog_msg, fs_mount_all_fs and corecmd_exec_bin the rest. The
module is 203 statements where the generated set was 806 rules.
packimage and liteimg are symlinks to xcatclientnnr, so their work runs in
the xcatd plugin and the tree authority stays in xcat_t with them. It can
move to xcat_image_t when the plugin execs a helper instead.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
The image build creates an operating system tree, so it writes and relabels
files of every type the packages own. xcat_t holds that authority today, and
the same domain listens on the xcatd port.
xcat_selinux_package.t now asserts a second domain for the build: the
xcat_image_t declaration, its permissive line, the entrypoint, the
transition from xcat_t with the three inherited process permissions, the
role statements for system_r and unconfined_r, and the file contexts of the
two genimage programs. One check holds the security property of the split:
only xcat_image_t may manage or relabel every file type, and the daemon
domain gets no filesystem-wide grant.
9 of the 74 checks fail on this commit.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
mysqlsetup -i reports
comment the bind-address line failed: cannot read : No such file or
directory
on every MySQL cluster, with no file named. Measured on xcat185-mn-tmp-84
through SN_setup_case, which then stops: the Kea configuration and the
service node install never happen.
@BIND_FILES is assigned by a top-level statement that sits below the main
flow's exit, so the statement never runs and the list is empty at run time.
$BIND_FILES[-1] is then undef. Each case in the test localizes the list, so
none of them read the value the script itself holds.
The test now asserts the list of the loaded script. 2 of its 15 checks fail
on this commit.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
Removing the package removes the module, so xcatd_exec_t and
xcat_client_exec_t leave the policy and each file that carried one becomes
unlabeled_t. Measured on xcat162-mn-tmp-286 after dnf remove:
system_u:object_r:unlabeled_t:s0 /opt/xcat/sbin/xcatd
system_u:object_r:unlabeled_t:s0 /opt/xcat/bin/xcatclient
system_u:object_r:unlabeled_t:s0 /opt/xcat/bin/xcatclientnnr
restorecon -n reported all three as pending, and /install kept
public_content_t, which the stock policy does not define for it.
xcat_selinux_package.t asserts the %preun snapshot and the %postun relabel
that an erase needs, guarded for the erase only. 3 of its 64 checks fail on
this commit.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
The cases marked the start of a window with date "+%x %T" and passed the
result to ausearch -ts. Audit 4.0.3 rejects it:
Invalid start time (10/14/2026 20:00:00). Hour, Minute, and Second are
required.
ausearch then exits 1 with that message and no records. Measured on
xcat162-mn-tmp-286: the query returned 0 records where 653 were in the log,
and MM/DD/YY and ISO forms are refused the same way. Only a bare HH:MM:SS
is accepted. Each no-denial check therefore reported a clean node whatever
the node did, which is the defect --input-logs was meant to remove.
Each case now seeds an ausearch --checkpoint file at its start and reads
the new events with the same file, which is audit's own mechanism and has
no date to misparse. A check before the count asserts that ausearch
answered at all: the output has to hold a record or "<no matches>", and an
error message holds neither. Verified on the same node, where the guard
exits 1 on a deliberately broken query, 0 on an empty window, and the read
after a client run returned 63 new records.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
A client command run from unconfined_t fails under enforcing:
/opt/xcat/bin/lsxcatd: /usr/bin/perl: bad interpreter: Permission denied
Measured on xcat162-mn-tmp-286, AlmaLinux 10.2, with the module loaded and
the entrypoints labelled. The same command returns 0 under setenforce 0.
The transition computes unconfined_u:unconfined_r:xcat_t, and the module
does not authorize unconfined_r for xcat_t, so the context is invalid and
the kernel refuses the exec. The permissive declaration does not help,
because an invalid context is not a permission check. The record is
SELINUX_ERR, op=security_compute_sid, which no AVC query finds.
xcat_selinux_package.t asserts the role statement, and check 49 of 60
fails on this commit. selinux_client_domain asserts that lsxcatd returns 0
and prints its version under enforcing, that seinfo reports xcat_t for
unconfined_r, and that the run leaves no invalid_context record.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
The unit file and xcatd_service_direct_exec.t said that a direct ExecStart
keeps xcatd out of initrc_t and in unconfined_service_t. The entrypoint of
the xcat_t domain is the xcatd script, so a shell in ExecStart now costs the
domain, not the confinement.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT ships no process domain. xcatd runs in unconfined_service_t, and a
client command runs in the domain of its caller, so no rule in the policy
module reaches either of them.
xcat_selinux_package.t now asserts the domain, the two entrypoint types,
the file contexts of the three entrypoints, the transition from systemd and
the transition from unconfined_t, and that no confined user domain gets a
transition. 9 of its 59 checks fail on this commit.
selinux_xcatd_domain asserts the live context of xcatd and its workers, and
the new selinux_client_domain case asserts the entrypoint labels and the
transition rules the loaded policy holds.
The two no-denial cases now count only the denials the kernel enforced,
because xcat_t is permissive and each access it needs is recorded. They also
pass --input-logs: on EL10 audit 4.0.3 ausearch reads the journal rather than
the file auditd.conf names, and answered "<no matches>" on a node whose log
held 1032 denials.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
No xcattest case checks xCAT on an enforcing management node, so an
SELinux denial in xcatd, httpd or the REST API reaches a release unseen.
selinux_xcatd_domain checks that xcatd and its workers run in
unconfined_service_t and not in initrc_t. selinux_mn_labels checks the
xcat module, the /install and rootimg file contexts, and that httpd
serves a file from /install and from /tftpboot. selinux_restapi_avc gets
a site attribute through xcatws.cgi. The last two read the audit log from
the start of the case and expect no AVC record. Every case first requires
getenforce to report Enforcing, and none carries the ci_test label.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
mysqlsetup commented the bind-address line by writing the result to
/tmp/my.cnf and renaming it over the configuration file. A file created in
/tmp takes user_tmp_t, and a rename keeps the type of the file it moves, so
the management node was left with a MySQL configuration that mysqld is denied
read of. The denial survives the command and was seen in three rounds of the
SELinux campaign. The temporary path is also a fixed name in a world writable
directory, written as root.
comment_bind_address now reads the file, substitutes the line and writes the
result back through the same file. Truncating in place keeps the inode, which
is what carries the label, so no relabel is needed afterwards. The candidate
list moves to @BIND_FILES and the resolution order does not change: the
Ubuntu mariadb.conf.d file, then /etc/mysql/my.cnf, then /etc/my.cnf.
mysqlsetup_bind_address_label.t drives the sub against a scratch tree and
asserts the inode survives, that only a line starting with bind is commented,
and that no temporary file is left beside the target. With the rewrite put back
through a renamed file in /tmp, the inode check is the one check of the
thirteen that fails.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
stage_genesis_payload() discarded the exit status of restorecon, so mknb
reported success with the staged kernel still carrying the context of the xCAT
install tree. The routine now returns that status, the kernel path and a message
that names the relabel, and process_request reports it. A failed copy keeps its
own message.
selinux_context.sh reads the exit status of restorecon -F -n -v before its
output, so a non-zero exit with no output is a failure.
The helper also resolves the name mknb stages instead of the architecture it was
given: the exact architecture when an OpenEmbedded export is installed, ppc64
for the legacy POWER image. When that kernel is absent it lists the kernels that
are present, so a mapping that no longer matches mknb is named rather than read
as a missing file.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
The unit test in this branch drives stage_genesis_payload with a stub runner, so
it reads the command mknb builds and never a context on disk. No xcattest case
reads one either, so a cell with SELinux enabled cannot show a Genesis kernel
that arrives in the TFTP root with the context of the xCAT install tree.
genesis_kernel_selinux_context deletes the staged kernel, runs mknb, and reports
whether restorecon -F -n -v finds a difference from the policy. cp keeps the
context of a destination that exists, so the delete is what makes the case
measure the copy. Where SELinux is disabled, or libselinux-utils is absent, the
case prints GENESIS_SELINUX_SKIPPED and passes. A permissive node applies labels
and is measured like an enforcing one.
Measured on an AlmaLinux 9.8 management node with SELinux permissive: without
the fix the case reports system_u:object_r:usr_t:s0 against the policy's
tftpdir_t and fails, and with the fix it reports tftpdir_t and passes.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
stage_genesis_payload() runs restorecon and discards its exit status, so a
relabel that fails returns 0 and the kernel keeps the context of the install
tree. mknb_genesis_selinux_context.t asserted that rc, so the test held the
defect in place. It now requires the failure to reach the caller, with the
kernel path and a message that names the relabel.
selinux_context.sh reads only the output of restorecon -F -n -v, so a non-zero
exit with no output reports GENESIS_SELINUX_OK.
The helper also builds genesis.kernel.<arch> from the architecture it was
given. With legacy Genesis, mknb ppc64le resolves share/xcat/netboot/genesis/
ppc64 and writes genesis.kernel.ppc64, so the helper fails on a kernel mknb
never staged. Three ppc64le cells run this case.
genesis_kernel_selinux_context.bats drives the helper with lsdef, mknb,
selinuxenabled and restorecon shadowed and XCATROOT in a scratch tree. Three of
its four checks fail without the fix that follows, and the fourth fails when the
OpenEmbedded branch is removed.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
mknb stages the legacy Genesis kernel with cp -a, which implies --preserve=all
and copies the SELinux context of /opt/xcat/share/xcat/netboot/genesis with it.
On a management node with SELinux enabled the kernel then carries usr_t, while
the policy declares tftpdir_t for that path. Measured on an el9 management node,
restorecon -nvR /tftpboot names genesis.kernel.x86_64 and no other path, so it
is the one file xCAT mislabels under the TFTP root. Nothing in the netboot path
relabels it.
stage_genesis_payload now copies with --no-preserve=context,xattr, and runs
restorecon -F on the staged kernel when xCAT::Utils->isSELINUX reports SELinux
enabled. xattr goes with context because cp stores the context in the
security.selinux xattr, so --no-preserve=context alone still copies it. The
relabel corrects a kernel that an earlier xCAT staged, because a copy over an
existing file keeps that file's context. A failed relabel does not fail the
step.
mknb_genesis_staging.t reports SELinux as disabled, so its command counts stay
about the copies it tests.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
mknb stages the legacy Genesis kernel into the TFTP root with cp -a. The flag
implies --preserve=all, so the kernel arrives with the SELinux context of the
xCAT install tree and not the context the policy declares for that path.
The test drives stage_genesis_payload with a recording runner. It asserts that
the copy does not preserve the context, and that the staged kernel is relabelled
after the copy when SELinux is enabled. It fails on the current code: 4 of its
14 checks are red.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
The xcat policy module carries four allow rules and xcat_selinux_package.t reads
only the spec and the file context list, so no test reads the module source. The
SELinux campaign measured five more accesses that the module does not grant:
httpd maps the per-node xnba boot config it serves, rsync reads /etc/shadow and
needs CAP_DAC_OVERRIDE to write it, and useradd and groupadd read the rootimg
/var/run symlink from an rpm scriptlet.
The test parses the allow rules of xcat.te into a permission set per source,
target and class, and asserts each access. It also asserts that no rule grants
kernel_t anything. Two such rules make an EL10 diskless node boot enforcing, and
they grant the pre-pivot domain execute on an unlabelled file, which on that
node is the whole root.
7 of the 43 checks fail on this commit.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xCAT ships no SELinux policy. On an enforcing management node, httpd
cannot read /install, which has no file context and is default_t, and
cannot read the /tftpboot files that xcat.conf serves. xcatws.cgi cannot
connect to xcatd.
xcat_selinux_package.t reads the xCAT-selinux spec, its file context list
and the xCAT-server and xCATsn specs. It checks the build and the
scriptlet macros, the /install labels, and the conditional Requires on
xCAT-selinux. 23 of its 31 checks fail on this commit.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xcatd.service starts xcatd through /bin/sh to read /etc/profile.d/xcat.sh.
systemd runs that shell in initrc_t, so on an SELinux system xcatd runs in
initrc_t. That domain moves rsync, useradd, groupadd, hwclock and setfiles
into confined domains, which deny syncfiles, updatenode -F and genimage.
xcatd_service_direct_exec.t reads the [Service] section of the unit and
checks that ExecStart runs /usr/sbin/xcatd and that Environment= carries
XCATROOT, PATH and PERL_BADLANG. 11 of its 14 checks fail on this commit.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
xcatconfig turns SELinux off during an installation. It sets the running
system permissive and writes SELINUX=disabled into /etc/selinux/config. A
management node therefore loses the SELinux policy of the site, and only a
warning in the log reports it. Every CI cell that declares SELINUX=enforcing
ran its test cases permissive for this reason.
The test drives xCAT::SELinux->xcatconfig_action against a scratch root and
asserts that an enforcing node, a permissive node and a node with SELinux
already off all get an answer that asks for no change. It also asserts that
the call rewrites no file under that root.
10 of the 27 checks fail on this commit.
Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com>
An extra file must go into its destination directory, which the import
creates with its missing parents. A file at the destination path, or at
a parent of it, must fail the import and stay as it was. A file name
with glob characters must stay literal. A failed backup of the previous
file must fail the import.
A cached reader that saw an update before a rollback must see the
committed value after the rollback. This also holds when the rollback
goes through another table on the same handle, and after a table failed
to open on that handle.
When the configured database is MySQL, the litefile lookup of a
statelite import must quote the image column with backticks. An ALL
entry must still cover the same file of the image.
A kit command must hold the kit lock while it runs, and release it
after. It must refuse to run while another process holds the lock, also
in a process that ran a kit command before. A kit command that another
kit command runs must go on under the lock of that command.