From fd8e60c21eb652eba8014bfb35836e48accb5631 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vin=C3=ADcius=20Ferr=C3=A3o?= <2031761+viniciusferrao@users.noreply.github.com> Date: Mon, 2 Nov 2026 19:36:18 -0300 Subject: [PATCH] test(install): start kdump on openEuler nodes only with dump memory The rendered compute and service %post, run in a sandbox through the downloaded postscript, must leave the kdump.service drop-in that stateless images get. A system without kdump.service must get none. --- .github/workflows/xcat_test.yml | 2 +- xCAT-test/native/openeuler_post_kdump.t | 86 +++++++++++++++++++++++++ 2 files changed, 87 insertions(+), 1 deletion(-) create mode 100644 xCAT-test/native/openeuler_post_kdump.t diff --git a/.github/workflows/xcat_test.yml b/.github/workflows/xcat_test.yml index 3fbad86536..a61196daa7 100644 --- a/.github/workflows/xcat_test.yml +++ b/.github/workflows/xcat_test.yml @@ -104,7 +104,7 @@ jobs: run: | log=$(mktemp) trap 'rm -f -- "$log"' EXIT - prove -v xCAT-test/native/install_profile_riscv64.t xCAT-test/native/netboot_profile_riscv64.t xCAT-test/native/netboot_profile_postinstall.t xCAT-test/native/kdump_condition_systemd.t xCAT-test/native/builddebs_riscv64.t xCAT-test/native/ubuntu_subiquity_template.t | tee "$log" + prove -v xCAT-test/native/install_profile_riscv64.t xCAT-test/native/netboot_profile_riscv64.t xCAT-test/native/netboot_profile_postinstall.t xCAT-test/native/kdump_condition_systemd.t xCAT-test/native/openeuler_post_kdump.t xCAT-test/native/builddebs_riscv64.t xCAT-test/native/ubuntu_subiquity_template.t | tee "$log" ! grep -qi skipped "$log" rpm_lifecycle_test: runs-on: ubuntu-24.04 diff --git a/xCAT-test/native/openeuler_post_kdump.t b/xCAT-test/native/openeuler_post_kdump.t new file mode 100644 index 0000000000..445858aff5 --- /dev/null +++ b/xCAT-test/native/openeuler_post_kdump.t @@ -0,0 +1,86 @@ +#!/usr/bin/env perl +use strict; +use warnings; + +use File::Copy qw(copy); +use File::Path qw(make_path); +use File::Slurper qw(read_text write_text); +use File::Temp qw(tempdir); +use FindBin; +use lib "$FindBin::Bin/../lib"; +use lib "$FindBin::Bin/../../perl-xCAT", "$FindBin::Bin/../../xCAT-server/lib/perl"; +use lib "$FindBin::Bin/../../xCAT-server/share/xcat/netboot/imgutils"; +use Test::More; + +use imgutils; +use XCAT::Test::File qw(repo_path); +use XCAT::Test::Sandbox qw(sandbox_root sandbox_run); +use XCAT::Test::Template qw(template_database set_row render_template); + +plan skip_all => 'kickstart %post execution requires Linux' unless $^O eq 'linux'; +my $database = template_database(); +require xCAT::SvrUtils; +set_row('passwd', {key => 'system', username => 'root'}, {password => '$6$fixture$encrypted'}); +set_row('nodetype', {node => 'node'}, {os => 'openeuler24.03sp4', arch => 'riscv64', provmethod => 'install'}); + +my $dropin = 'etc/systemd/system/kdump.service.d/xcat-dump-memory.conf'; +my $image = tempdir(CLEANUP => 1); +make_path("$image/usr/lib/systemd/system"); +write_text("$image/usr/lib/systemd/system/kdump.service", "[Service]\n"); +imgutils::skip_kdump_without_dump_memory($image); +my $stateless = read_text("$image/$dropin"); + +sub post_root { + my (%units) = @_; + my $root = sandbox_root(); + make_path("$root/units", "$root/etc/systemd/system", "$root/etc/yum.repos.d"); + write_text("$root/units/$_", $units{$_}) for keys %units; + write_text("$root/tmp/pre-install.log", "pre-install fixture diagnostic\n"); + copy(repo_path('xCAT/postscripts/xcatlib.sh'), "$root/xcatlib.sh") or die $!; + write_text("$root/mypostscript.node", "#!/bin/bash\nMASTER=192.0.2.1\ntouch /fixture/postscript-ran\n"); + for my $name (qw(curl logger sleep updateflag.awk nmcli openssl)) { + copy(repo_path('xCAT-test/fixtures/install-profile/command'), "$root/bin/$name") or die $!; + chmod 0755, "$root/bin/$name" or die $!; + } + return $root; +} + +my $base = repo_path('xCAT-server/share/xcat/install/openeuler'); +for my $profile (qw(compute service)) { + subtest "$profile post-install sequence" => sub { + my $tmpl = xCAT::SvrUtils->get_tmpl_file_name($base, $profile, 'openeuler24.03sp4', 'riscv64'); + my $pkglist = xCAT::SvrUtils->get_pkglist_file_name($base, $profile, 'openeuler24.03sp4', 'riscv64'); + my $output = "$database/$profile.ks"; + render_template($database, $tmpl, $output, 'node', $pkglist, '/install/media', 'openeuler', undef, + {xcatmaster => '192.0.2.1'}); + my @posts; + my $rendered = read_text($output); + while ($rendered =~ /^%post([^\n]*)\n(.*?)^%end/msg) { + push @posts, [$1, $2]; + } + ok(@posts, 'renders a %post section'); + + for my $case ( + [{'kdump.service' => "[Service]\nExecStart=/usr/bin/kdumpctl start\n"}, $stateless, + 'installs the drop-in that stateless images get'], + [{'NetworkManager.service' => "[Service]\n"}, undef, 'adds no drop-in without kdump.service'], + ) { + my ($units, $expected, $label) = @$case; + my $root = post_root(%$units); + my $index = 0; + for my $post (@posts) { + my ($interpreter) = $post->[0] =~ /--interpreter=(\S+)/; + write_text("$root/post.sh", $post->[1]); + my ($rc, $log) = sandbox_run($root, {read_only => {"$root/units" => '/usr/lib/systemd/system'}}, + 'timeout', '30', $interpreter // '/bin/sh', '/fixture/post.sh'); + is($rc, 0, '%post section ' . ++$index . ' completes') + or diag($log, read_text("$root/log/xcat/xcat.log")); + } + ok(-e "$root/postscript-ran", 'runs the rendered sequence through the downloaded postscript'); + ok(!-e "$root/unexpected-command", 'external fixtures accept the requested operations'); + is(-f "$root/$dropin" ? read_text("$root/$dropin") : undef, $expected, $label); + } + }; +} + +done_testing();