From fd32ae68608c6f0113b38bd7c3f27fa288d32b6b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vin=C3=ADcius=20Ferr=C3=A3o?= <2031761+viniciusferrao@users.noreply.github.com> Date: Sat, 18 Jul 2026 16:46:49 -0300 Subject: [PATCH] refactor(dbobjutils): reuse only-if matcher for table routing --- perl-xCAT/xCAT/DBobjUtils.pm | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/perl-xCAT/xCAT/DBobjUtils.pm b/perl-xCAT/xCAT/DBobjUtils.pm index 8036e0e5a..f0eeec592 100644 --- a/perl-xCAT/xCAT/DBobjUtils.pm +++ b/perl-xCAT/xCAT/DBobjUtils.pm @@ -1090,17 +1090,12 @@ sub setobjdefs next; } - my $grp_matches_check_value = 0; - foreach my $tmpgrp (@tmplgrplist) { - if ($DBgroupsattr{$tmpgrp}{$check_attr} && $DBgroupsattr{$tmpgrp}{$check_attr} =~ /\b$check_value\b/) { - $grp_matches_check_value = 1; - last; - } - } - - my $obj_val = $objhash{$objname}{$check_attr} || ''; - my $db_val = $DBattrvals{$objname}{$check_attr} || ''; - if (!($obj_val =~ /\b$check_value\b/) && !($db_val =~ /\b$check_value\b/) && !$grp_matches_check_value) { + if (!_only_if_value_matches( + $objhash{$objname}, + $DBattrvals{$objname}, + \%DBgroupsattr, + $check_attr, + $check_value)) { if ($invalidattr->{$attr_name}->{valid} != 1) { $invalidattr->{$attr_name}->{valid} = 0; $invalidattr->{$attr_name}->{condition}=$check_attr;