From d3e4d010db5bdcc98e19a443558c531e01b6f2c8 Mon Sep 17 00:00:00 2001 From: Daniel Hilst <392820+dhilst@users.noreply.github.com> Date: Wed, 28 Oct 2026 08:35:40 -0300 Subject: [PATCH] test(packaging): a bail-out in the openSUSE spec test stops the whole suite opensuse_pod2man_buildrequires.t called BAIL_OUT when rpmspec exited non-zero. prove stops every remaining file on a bail-out, not only the one that called it, so one unreadable spec would hide the result of the rest of the suite. The close failure now dies, which fails that file alone. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com> --- xCAT-test/unit/opensuse_pod2man_buildrequires.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xCAT-test/unit/opensuse_pod2man_buildrequires.t b/xCAT-test/unit/opensuse_pod2man_buildrequires.t index bd83fd48e9..8e5e42a4fc 100644 --- a/xCAT-test/unit/opensuse_pod2man_buildrequires.t +++ b/xCAT-test/unit/opensuse_pod2man_buildrequires.t @@ -34,7 +34,7 @@ sub build_requires { '--undefine', 'rhel', '--undefine', 'suse_version', '--undefine', 'openEuler', '--define', $define, repo_path($spec)) or die "run rpmspec: $!"; my @requires = <$fh>; - close($fh) or BAIL_OUT("rpmspec failed for $spec with $define"); + close($fh) or die "rpmspec failed for $spec with $define"; chomp @requires; return @requires; }