From 8176947a1c93deaf8ec08266d3a03ad76bae90d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vin=C3=ADcius=20Ferr=C3=A3o?= <2031761+viniciusferrao@users.noreply.github.com> Date: Sat, 25 Apr 2026 16:42:42 -0300 Subject: [PATCH] fix: remove only_if mgt=kvm guard from vm table attributes Five vm attributes (vmhost, vmothersetting, vmmemory, vmcpus, vmnics) had an only_if => 'mgt=kvm' guard in Schema.pm that silently hid them from lsdef output unless mgt=kvm was set. The other 16 vm attributes had no such guard. This inconsistency caused the documented regex example in "Groups and Regular Expressions in Tables" to produce incomplete output. Fixes: xcat2/xcat-core#3006 --- perl-xCAT/xCAT/Schema.pm | 5 ----- 1 file changed, 5 deletions(-) diff --git a/perl-xCAT/xCAT/Schema.pm b/perl-xCAT/xCAT/Schema.pm index 4c73f2aee..ccf28edec 100644 --- a/perl-xCAT/xCAT/Schema.pm +++ b/perl-xCAT/xCAT/Schema.pm @@ -2717,7 +2717,6 @@ my @nodeattrs = ( access_tabentry => 'vm.node=attr:node', }, { attr_name => 'vmhost', - only_if => 'mgt=kvm', tabentry => 'vm.host', access_tabentry => 'vm.node=attr:node', }, @@ -2734,7 +2733,6 @@ my @nodeattrs = ( access_tabentry => 'vm.node=attr:node', }, { attr_name => 'vmothersetting', - only_if => 'mgt=kvm', tabentry => 'vm.othersettings', access_tabentry => 'vm.node=attr:node', }, @@ -2755,17 +2753,14 @@ my @nodeattrs = ( access_tabentry => 'vm.node=attr:node', }, { attr_name => 'vmmemory', - only_if => 'mgt=kvm', tabentry => 'vm.memory', access_tabentry => 'vm.node=attr:node', }, { attr_name => 'vmcpus', - only_if => 'mgt=kvm', tabentry => 'vm.cpus', access_tabentry => 'vm.node=attr:node', }, { attr_name => 'vmnics', - only_if => 'mgt=kvm', tabentry => 'vm.nics', access_tabentry => 'vm.node=attr:node', },