test(xCAT-test): cover the apt calls of ospkgs and otherpkgs

xcat_apt_get is sourced from xcatpkgutils.sh and called with a shadowed apt-get that records its environment and arguments. The apt block of ospkgs and the two apt commands of otherpkgs are extracted from the scripts and executed the same way, since neither script can be sourced. Against the previous scripts 6 of the 7 tests fail: the helper does not exist, and the recorded calls carry --force-yes. Signed-off-by: Vinícius Ferrão <2031761+viniciusferrao@users.noreply.github.com>
2026-09-22 09:32:27 +00:00 · 2026-09-09 19:58:32 -03:00
parent fa00892778
commit c7b442598e
1 changed files with 137 additions and 0 deletions
@@ -0,0 +1,137 @@
+#!/usr/bin/env bats
+
+load 'helpers/shell_source'
+
+setup()
+{
+    PKGUTILS="$(repo_path 'xCAT/postscripts/xcatpkgutils.sh')"
+    OSPKGS="$(repo_path 'xCAT/postscripts/ospkgs')"
+    OTHERPKGS="$(repo_path 'xCAT/postscripts/otherpkgs')"
+    [ -r "$PKGUTILS" ] || skip "$PKGUTILS is required"
+    [ -r "$OSPKGS" ] || skip "$OSPKGS is required"
+    [ -r "$OTHERPKGS" ] || skip "$OTHERPKGS is required"
+    APT_LOG="${BATS_TEST_TMPDIR}/apt-get.log"
+    export PKGUTILS OSPKGS OTHERPKGS APT_LOG
+}
+
+# Every apt-get call is recorded as "<DEBIAN_FRONTEND>|<arguments>" and answers with APT_STATUS.
+shadow_apt_get()
+{
+    apt-get()
+    {
+        printf '%s|%s\n' "${DEBIAN_FRONTEND:-unset}" "$*" >>"$APT_LOG"
+        return "${APT_STATUS:-0}"
+    }
+}
+
+apt_call()
+{
+    sed -n "${1}p" "$APT_LOG"
+}
+
+apt_calls()
+{
+    wc -l <"$APT_LOG" | tr -d ' '
+}
+
+run_ospkgs_apt_block()
+{
+    local block
+    block="$(extract_line_range "$OSPKGS" '# upgrade existing packages' '# remove packages')" || return 99
+    local ENVLIST="" groups="" pkgs=" foo bar" cudapkgs="" RETURNVAL=0 ARCH=x86_64
+    eval "$block"
+    printf 'RETURNVAL=%s\n' "$RETURNVAL"
+}
+
+run_otherpkgs_apt_line()
+{
+    local line
+    line="$(extract_first_matching_line "$OTHERPKGS" "$1")" || return 99
+    local envlist="" repo_pkgs="foo bar" result=""
+    eval "$line"
+    printf 'R=%s\n' "$?"
+    printf '%s\n' "$result"
+}
+
+@test "the postscripts and the package utilities ship executable" {
+    [ -x "$OSPKGS" ]
+    [ -x "$OTHERPKGS" ]
+    [ -x "$PKGUTILS" ]
+}
+
+@test "xcat_apt_get runs apt-get unattended and accepts the unsigned xCAT repositories" {
+    source "$PKGUTILS"
+    shadow_apt_get
+
+    run xcat_apt_get -q install --no-install-recommends foo bar
+    [ "$status" -eq 0 ]
+    [ "$(apt_call 1)" = "noninteractive|-y --allow-unauthenticated -q install --no-install-recommends foo bar" ]
+    [ "$(apt_calls)" -eq 1 ]
+}
+
+@test "xcat_apt_get returns the apt-get status" {
+    source "$PKGUTILS"
+    shadow_apt_get
+
+    APT_STATUS=100 run xcat_apt_get upgrade
+    [ "$status" -eq 100 ]
+}
+
+@test "a pkglist environment prefix reaches apt-get through the eval the postscripts use" {
+    source "$PKGUTILS"
+    apt-get()
+    {
+        printf '%s\n' "${ACCEPT_EULA:-unset}" >>"$APT_LOG"
+    }
+    local ENVLIST="ACCEPT_EULA=y"
+
+    run eval "$ENVLIST xcat_apt_get -q install foo"
+    [ "$status" -eq 0 ]
+    [ "$(apt_call 1)" = "y" ]
+}
+
+@test "ospkgs upgrades and installs through xcat_apt_get without --force-yes" {
+    source "$PKGUTILS"
+    shadow_apt_get
+
+    run run_ospkgs_apt_block
+    [ "$status" -eq 0 ]
+    [[ "$output" == *'RETURNVAL=0'* ]]
+    [ "$(apt_call 1 | cut -d'|' -f2)" = "-y update" ]
+    [ "$(apt_call 2)" = "noninteractive|-y --allow-unauthenticated -o Dpkg::Options::=--force-confold -o Dpkg::Options::=--force-confdef upgrade" ]
+    [ "$(apt_call 3)" = "noninteractive|-y --allow-unauthenticated -q install --no-install-recommends foo bar" ]
+    [ "$(apt_calls)" -eq 3 ]
+    ! grep -q -- '--force-yes' "$APT_LOG"
+}
+
+@test "ospkgs keeps the apt-get failure status and still runs the later steps" {
+    source "$PKGUTILS"
+    shadow_apt_get
+
+    APT_STATUS=100 run run_ospkgs_apt_block
+    [ "$status" -eq 0 ]
+    [[ "$output" == *'RETURNVAL=100'* ]]
+    [ "$(apt_calls)" -eq 3 ]
+}
+
+@test "otherpkgs upgrades through xcat_apt_get without --force-yes" {
+    source "$PKGUTILS"
+    shadow_apt_get
+
+    run run_otherpkgs_apt_line 'result=`eval [$]envlist .*Dpkg::Options.* upgrade 2>&1`'
+    [ "$status" -eq 0 ]
+    [[ "$output" == *'R=0'* ]]
+    [ "$(apt_call 1)" = "noninteractive|-y --allow-unauthenticated -o Dpkg::Options::=--force-confold -o Dpkg::Options::=--force-confdef upgrade" ]
+    [ "$(apt_calls)" -eq 1 ]
+}
+
+@test "otherpkgs installs through xcat_apt_get without --force-yes" {
+    source "$PKGUTILS"
+    shadow_apt_get
+
+    run run_otherpkgs_apt_line 'result=`eval [$]envlist .*Dpkg::Options.* install [$]repo_pkgs 2>&1`'
+    [ "$status" -eq 0 ]
+    [[ "$output" == *'R=0'* ]]
+    [ "$(apt_call 1)" = "noninteractive|-y --allow-unauthenticated -q -o Dpkg::Options::=--force-confold -o Dpkg::Options::=--force-confdef install foo bar" ]
+    [ "$(apt_calls)" -eq 1 ]
+}