From bc4ddbe34ebf22ec2d2c94fb643376cd197d202b Mon Sep 17 00:00:00 2001 From: Daniel Hilst <392820+dhilst@users.noreply.github.com> Date: Tue, 15 Sep 2026 21:10:56 -0300 Subject: [PATCH] fix(xcat-core): builddebs_release_placeholder.t passes when the file it reads is missing builddebs_release_placeholder.t called plan skip_all when builddebs.pl was absent, so a checkout that lost the file reported 0 tests and exit 0. A test that cannot fail measures nothing. Die instead, which is what makentp_ntp_deps.t already does for setupntp. With builddebs.pl moved aside the file now exits 2 and prints "builddebs.pl not found"; before this change it exited 0 and printed "1..0 # SKIP builddebs.pl not found". With the file present the test passes either way. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com> --- xCAT-test/unit/builddebs_release_placeholder.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xCAT-test/unit/builddebs_release_placeholder.t b/xCAT-test/unit/builddebs_release_placeholder.t index d17f2b7a4..341681af5 100644 --- a/xCAT-test/unit/builddebs_release_placeholder.t +++ b/xCAT-test/unit/builddebs_release_placeholder.t @@ -18,7 +18,7 @@ use XCAT::BuildUtils qw(read_line snap_release); my $repo_root = File::Spec->rel2abs( File::Spec->catdir( $FindBin::Bin, '..', '..' ) ); my $builder = File::Spec->catfile( $repo_root, 'builddebs.pl' ); -plan skip_all => "builddebs.pl not found" unless -f $builder; +die "builddebs.pl not found\n" unless -f $builder; my $src = do { local $/; open my $fh, '<', $builder or die $!; <$fh> };