From b6f9294a792ef623dcad7b2eff2a4f424f05d1c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vin=C3=ADcius=20Ferr=C3=A3o?= <2031761+viniciusferrao@users.noreply.github.com> Date: Thu, 22 Oct 2026 17:11:34 -0300 Subject: [PATCH] test(debian): exercise service callers in proc-mounted chroots --- .github/workflows/xcat_test.yml | 2 +- xCAT-test/native/debian_chroot_services.t | 147 ++++++++++++++++++++++ 2 files changed, 148 insertions(+), 1 deletion(-) create mode 100644 xCAT-test/native/debian_chroot_services.t diff --git a/.github/workflows/xcat_test.yml b/.github/workflows/xcat_test.yml index 629fc208f0..a7086fc57f 100644 --- a/.github/workflows/xcat_test.yml +++ b/.github/workflows/xcat_test.yml @@ -15,7 +15,7 @@ jobs: - name: Install lifecycle test dependencies run: sudo env DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends --no-install-suggests ucf debconf-utils systemd libxml-simple-perl apache2 curl - name: Test Debian package lifecycle - run: prove -v xCAT-test/native/xcatd_debian_lifecycle.t xCAT-test/native/xcatd_restart_callers.t xCAT-test/native/apache_package_lifecycle.t xCAT-test/native/package_upgrade_logging.t xCAT-test/native/profile_package_payload.t + run: prove -v xCAT-test/native/xcatd_debian_lifecycle.t xCAT-test/native/xcatd_restart_callers.t xCAT-test/native/debian_chroot_services.t xCAT-test/native/apache_package_lifecycle.t xCAT-test/native/package_upgrade_logging.t xCAT-test/native/profile_package_payload.t - name: Test optional statelite host keys if: ${{ !cancelled() }} run: prove -v xCAT-test/native/statelite_optional_hostkey.t diff --git a/xCAT-test/native/debian_chroot_services.t b/xCAT-test/native/debian_chroot_services.t new file mode 100644 index 0000000000..10362f1581 --- /dev/null +++ b/xCAT-test/native/debian_chroot_services.t @@ -0,0 +1,147 @@ +#!/usr/bin/env perl +use strict; +use warnings; +use FindBin; +use lib "$FindBin::Bin/../lib"; +use Test::More; +use File::Path qw(make_path); +use XCAT::Test::Lifecycle; + +plan skip_all => 'Run as an ordinary user on Debian or Ubuntu' + unless $^O eq 'linux' && $< != 0 && -f '/etc/debian_version'; +my %packages = map { $_ => XCAT::Test::Lifecycle::build_deb($_) } + qw(xCAT-server xCATsn); + +sub succeeds { + my ($label, @result) = @_; + is($result[0], 0, $label) or diag "$result[1]$result[2]"; +} + +for my $mode (qw(without-proc live proc-chroot systemd-chroot)) { + subtest $mode => sub { + my $root = XCAT::Test::Lifecycle->new; + $root->{live} = $mode ne 'without-proc'; + $root->{chroot} = $mode =~ /chroot/ ? 1 : 0; + my $active = $mode eq 'live'; + { + local $root->{deb} = $packages{'xCAT-server'}; + succeeds('unpack the server payload', $root->run('dpkg-deb', '-x', '/package.deb', '/unpacked')); + } + make_path(map { $root->path($_) } qw(/opt/xcat/lib /opt/xcat/sbin /opt/xcat/share/xcat /etc/apache2/conf-enabled)); + succeeds('stage packaged helpers', $root->run('cp', '-a', + '/unpacked/opt/xcat/share/xcat/scripts', '/opt/xcat/share/xcat/')); + succeeds('stage the packaged fast-restart command', $root->run('cp', + '/unpacked/opt/xcat/sbin/restartxcatd', '/opt/xcat/sbin/')); + symlink '/source/perl-xCAT', $root->path('/opt/xcat/lib/perl') or die "link Perl modules: $!"; + $root->write('/etc/os-release', $mode eq 'systemd-chroot' + ? "ID=ubuntu\nVERSION_ID=24.04\n" : "ID=ubuntu\nVERSION_ID=14.04\n"); + make_path($root->path('/run/systemd/system')) if $mode eq 'systemd-chroot'; + succeeds('install the packaged legacy init script', $root->run('cp', + '/opt/xcat/share/xcat/scripts/xcatd', '/etc/init.d/xcatd')); + if ($mode eq 'systemd-chroot') { + for my $service (qw(xcatd xcat-uftp-listener)) { + succeeds("stage the $service unit", $root->run('cp', + "/unpacked/lib/systemd/system/$service.service", '/usr/lib/systemd/system/')); + succeeds("enable $service in the image", $root->run('systemctl', 'enable', "$service.service")); + ok(-l $root->path("/etc/systemd/system/multi-user.target.wants/$service.service"), + "$service starts with an enabled link"); + } + } else { + succeeds('register xcatd in the image', $root->run('update-rc.d', 'xcatd', 'defaults')); + my @enabled = glob $root->path('/etc/rc?.d/S??xcatd'); + ok(@enabled, 'xcatd starts with enabled runlevels'); + } + $root->write('/etc/profile.d/xcat.sh', + "export XCATROOT=/opt/xcat\nexport PATH=/opt/xcat/sbin:/usr/sbin:/usr/bin:/sbin:/bin\n"); + unlink $root->path('/usr/sbin/policy-rc.d') or die "unlink policy fixture: $!" + if -l $root->path('/usr/sbin/policy-rc.d'); + $root->write('/usr/sbin/policy-rc.d', <<'SH', oct('755')); +#!/bin/sh +printf '%s\n' "$*" >> /policy-calls +exit 101 +SH + $root->record_command('/opt/xcat/sbin/xcatd'); + $root->record_command('/etc/init.d/apache2'); + $root->write('/etc/init.d/apache2', $root->read('/etc/init.d/apache2') . <<'SH', oct('755')); +### BEGIN INIT INFO +# Provides: apache2 +# Required-Start: $network +# Required-Stop: +# Default-Start: 2 3 4 5 +# Default-Stop: 0 1 6 +# Short-Description: Apache command boundary +### END INIT INFO +SH + succeeds('register the Apache dependency', $root->run('update-rc.d', 'apache2', 'defaults')); + $root->write('/calls', ''); + if ($root->{chroot}) { + succeeds('proc is mounted inside a different process root', $root->run('/bin/sh', '-c', + q{test -f /proc/cmdline && test "$(stat -c '%d:%i' /)" != "$(stat -c '%d:%i' /proc/1/root/.)"})); + } + if ($mode ne 'systemd-chroot') { + succeeds('native service policy denies an explicit start', + $root->run('invoke-rc.d', 'xcatd', 'start')); + is($root->read('/calls'), '', 'the policy control cannot reach the daemon'); + like($root->read('/policy-calls'), qr/xcatd.*start/, 'the native dispatcher consulted policy'); + } + succeeds('configure the service-node package', + $root->deb_script($packages{'xCATsn'}, 'postinst', 'configure')); + is($root->read('/calls'), $active + ? "xcatd <-p> \napache2 \n" : '', + 'only the live root starts xcatd and reloads Apache'); + $root->write('/calls', ''); + succeeds('upgrade the Perl package through the real fast-restart command', + $root->run('/bin/sh', '/source/perl-xCAT/debian/postrm', 'upgrade', '2.20.0')); + is($root->read('/calls'), $active ? "xcatd <-p> \n" : '', + 'only the live root reaches xcatd through restartxcatd'); + + $root->write('/sentinel.pl', <<'PERL'); +use strict; +use warnings; +$0 = 'xcatd: lifecycle sentinel'; +$SIG{TERM} = sub { open(my $fh, '>', '/stopped') or die $!; print {$fh} "TERM\n"; close($fh); exit 0; }; +open(my $pid, '>', '/var/run/xcatd.pid') or die $!; +print {$pid} "$$\n"; +close($pid) or die $!; +sleep 1 while 1; +PERL + local $root->{deb} = $packages{'xCAT-server'}; + succeeds('unpack the server control scripts', + $root->run('dpkg-deb', '-e', '/package.deb', '/tmp/server-control')); + succeeds('remove the server while an isolated process is running', + $root->run('/bin/sh', '-c', <<'SH', 'remove', $active ? 'live' : 'image')); +set -eu +mkdir -p /var/run +perl /sentinel.pl & +daemon=$! +trap 'kill -KILL "$daemon" 2>/dev/null || :; wait "$daemon" 2>/dev/null || :' EXIT +attempt=0 +until test -s /var/run/xcatd.pid; do + attempt=$((attempt + 1)) + test "$attempt" -lt 100 || exit 20 + sleep .05 +done +/bin/sh /tmp/server-control/prerm remove +if [ "$1" = live ]; then + test -f /stopped + test ! -f /var/run/xcatd.pid +else + kill -0 "$daemon" + test ! -f /stopped + test -f /var/run/xcatd.pid +fi +SH + is(-e $root->path('/stopped') ? $root->read('/stopped') : '', + $active ? "TERM\n" : '', 'only live-root removal signals the process'); + if ($mode eq 'systemd-chroot') { + for my $service (qw(xcatd xcat-uftp-listener)) { + ok(!-l $root->path("/etc/systemd/system/multi-user.target.wants/$service.service"), + "removal disables $service without starting the image"); + } + } else { + my @links = glob $root->path('/etc/rc?.d/S??xcatd'); + is_deeply(\@links, [], 'removal still disables offline service registration'); + } + }; +} +done_testing;