From 6dfcdcbc48601cd040925ef65f7df448e01b6267 Mon Sep 17 00:00:00 2001 From: Daniel Hilst <392820+dhilst@users.noreply.github.com> Date: Sat, 24 Oct 2026 11:27:04 -0300 Subject: [PATCH] fix(xcat-core): getpostscript serves no node when the management node cannot reverse-resolve it A diskless openEuler 22.03sp4 node netbooted, took a lease, reached a login prompt and answered ping, and then every xdsh and ssh answered "root@xcat59-cn: Permission denied (publickey)" while the node never reported "booted". reg_linux_diskless_installation_flat failed after 7072 s. xcatd on that management node logged "xCAT: Allowing getpostscript xcat59-cn" with no "from ", then "Received malformed getpostscript requesting, ignore it." -- 100 times, with 0 "Sending scripts data" in the whole log. The green openEuler 24.03sp4 cell beside it logged 3 sends and 0 malformed. The client certificate named the node correctly; only the reverse lookup of the peer socket failed. getpostscript read _xcat_clienthost and nothing else, so it dropped every request. No postscript ran: remoteshell never installed root's authorized_keys, which is the ssh failure, and nothing updated node status, which is the stuck "powering-on". One cause, both symptoms. process_request now tries each name xCAT::DiscoveryUtils::request_client_names offers and takes the first that correlates to a node. A request that offers no name at all, and one whose names correlate to nothing, are now reported as what they are; the old message said the request was malformed, which sent two investigations into DNS and the netboot image. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com> --- xCAT-server/lib/xcat/plugins/getpostscript.pm | 27 ++++++++++++------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/xCAT-server/lib/xcat/plugins/getpostscript.pm b/xCAT-server/lib/xcat/plugins/getpostscript.pm index 2ba655dd35..130ee1ba61 100644 --- a/xCAT-server/lib/xcat/plugins/getpostscript.pm +++ b/xCAT-server/lib/xcat/plugins/getpostscript.pm @@ -11,6 +11,7 @@ package xCAT_plugin::getpostscript; use xCAT::Utils; use xCAT::MsgUtils; use xCAT::NodeRange; +use xCAT::DiscoveryUtils; 1; #------------------------------------------------------- @@ -57,23 +58,31 @@ sub process_request my $client; + my @candidates; if ($::XCATSITEVALS{nodeauthentication}) { #if requiring node authentication, this request will have a certificate associated with it, use it instead of name resolution unless (ref $request->{username}) { return; } #TODO: log an attempt without credentials? - $client = $request->{username}->[0]; + @candidates = ($request->{username}->[0]); } else { - unless ($request->{'_xcat_clienthost'}->[0]) { - - #ERROR? malformed request - xCAT::MsgUtils->trace(0, 'E', "Received malformed getpostscript requesting, ignore it."); + # The peer host and fqdn are a reverse lookup of the client socket, so both are empty when + # that lookup fails, however good the client credentials are. Asking only for the peer host + # cost every postscript of an openEuler 22.03sp4 node on 2026-10-24: the certificate named + # the node, the reverse lookup did not, and 100 requests were dropped while 0 were served. + # request_client_names adds the certificate name, and excludes the request's own node + # attribute, which the client sends and has not proved. + @candidates = xCAT::DiscoveryUtils::request_client_names($request); + unless (@candidates) { + xCAT::MsgUtils->trace(0, 'E', "Received getpostscript from a client this request does not identify: it carries no peer name and no client certificate name. Ignoring it."); return; } - $client = $request->{'_xcat_clienthost'}->[0]; } - my $origclient = $client; - if ($client) { ($client) = noderange($client) } + foreach my $candidate (@candidates) { + next unless defined $candidate && $candidate ne ''; + my ($node) = noderange($candidate); + if ($node) { $client = $node; last; } + } unless ($client) { #Not able to do identify the host in question - xCAT::MsgUtils->trace(0, "E", "Received getpostscript from $origclient, which couldn't be correlated to a node (domain mismatch?)"); + xCAT::MsgUtils->trace(0, "E", "Received getpostscript from " . join(', ', @candidates) . ", none of which could be correlated to a node (domain mismatch?)"); return; } my $state;