From 40fec5d397fae3f50435b49a2a165c86e104bfcb Mon Sep 17 00:00:00 2001 From: Daniel Hilst <392820+dhilst@users.noreply.github.com> Date: Tue, 15 Sep 2026 21:11:14 -0300 Subject: [PATCH] fix(xcat-core): postscript_heredoc_embedding.t passes when the file it reads is missing postscript_heredoc_embedding.t called plan skip_all when xCAT-server/share/xcat/install/scripts was absent, so a checkout that lost the file reported 0 tests and exit 0. A test that cannot fail measures nothing. Die instead, which is what makentp_ntp_deps.t already does for setupntp. With xCAT-server/share/xcat/install/scripts moved aside the file now exits 2 and prints " not found"; before this change it exited 0 and printed "1..0 # SKIP not found". With the file present the test passes either way. Signed-off-by: Daniel Hilst <392820+dhilst@users.noreply.github.com> (cherry picked from commit fdc96de015573a8c23a81488de58a323051a1564) --- xCAT-test/unit/postscript_heredoc_embedding.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xCAT-test/unit/postscript_heredoc_embedding.t b/xCAT-test/unit/postscript_heredoc_embedding.t index 6960761b8..32d6c17c6 100644 --- a/xCAT-test/unit/postscript_heredoc_embedding.t +++ b/xCAT-test/unit/postscript_heredoc_embedding.t @@ -18,7 +18,7 @@ use Test::More; my $root = "$FindBin::Bin/../.."; my $scriptdir = "$root/xCAT-server/share/xcat/install/scripts"; -plan skip_all => "$scriptdir not found" unless -d $scriptdir; +die "$scriptdir not found\n" unless -d $scriptdir; # Return every (post script, delimiter, embedded file) the install scripts declare. sub embeddings {