mirror of
https://github.com/xcat2/confluent.git
synced 2026-09-01 15:06:06 +00:00
Markus Hilger
fd84d38bbd
pyghmi asks for this parameter with xraw_command and catches the completion code for a bmc that does not have it, and folding aiohmi in renamed that call to oldraw_command rather than raw_command, so the handler could no longer fire. Answering the code out of the returned dictionary repaired the crash but kept the call on the older contract, which is now the only one left in the tree. Catch it again instead: raw_command puts the completion code on the exception as ipmicode, and nothing here reads the payload of a reply that carries a code, which is the one thing catching gives up. No behaviour change, checked against the previous version over the same fake session for a good reply, an empty one, 0x80 and 0xC9 with and without a stray payload, four other completion codes, a timeout, a lost session and a reply with no data at all: same return value, same exception type, text and ipmicode, same bytes on the wire.