mirror of
https://github.com/xcat2/confluent.git
synced 2026-09-05 12:37:56 +00:00
Markus Hilger
db22a3e41a
The oem lookup answers whether it found a handler for the vendor, and that answer was being stored as whether the lookup had been done at all. On anything the map does not name, which is every bmc that is not a Lenovo, the flag stayed false and each oem_init issued another Get Device ID and built another handler. Almost everything goes through oem_init, so this is a round trip added to almost every operation. Where those calls are close together it is far worse than that: reading the sensor data records asks for the event constants once per record, so a run of 172 records fired 176 Get Device ID commands back to back, which was enough to make the bmc stop answering and the read fail with a timeout. The same sequence now takes 3 commands. Settling for the generic handler is an answer. The device id cannot change within a session, so asking again buys nothing, and the handler it throws away each time is the one holding the sensor names it had cached.