mirror of
https://github.com/xcat2/confluent.git
synced 2026-09-05 12:37:56 +00:00
Markus Hilger
3d79c3535d
The enforced rule set is deliberately narrow: undefined names, statements in impossible positions, duplicate definitions, invalid escapes and a couple of bugbear checks that only fire on genuine defects. No style rules, and the tree is clean under it as of the preceding commits. Discovery needs help. Ruff only walks *.py, and about a quarter of the Python here has no extension: every node* CLI tool, the server bin tools, the osdeploy scripts (some of which carry no shebang either) and the setup.py templates. extend-include lists them, and *.sh is excluded so the shell scripts sharing those directories are not parsed as Python. The CI job pins both the action and the ruff version, since there is no pyproject.toml for the action to read a version from and an unpinned `latest` would let a new ruff release fail an unchanged branch.
84 lines
2.8 KiB
YAML
84 lines
2.8 KiB
YAML
name: CI
|
|
|
|
on:
|
|
push:
|
|
pull_request:
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
ShellCheck:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
- name: Run ShellCheck (errors only)
|
|
# Check every tracked file that has a .sh extension or an sh/bash
|
|
# shebang. SC2148 (missing shebang) is excluded because many .sh
|
|
# files are sourced fragments or dracut hooks; ShellCheck then
|
|
# falls back to checking them as bash.
|
|
run: |
|
|
{
|
|
git ls-files '*.sh'
|
|
git ls-files | while IFS= read -r f; do
|
|
[ -f "$f" ] || continue
|
|
head -c 200 "$f" | head -n 1 | \
|
|
grep -qE '^#!.*[/ ](sh|bash|dash|ash|ksh)([ \t]|$)' && echo "$f"
|
|
done
|
|
} | sort -u | xargs -d '\n' shellcheck --severity=error --exclude=SC2148
|
|
|
|
ruff:
|
|
name: Ruff
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
# Pinned to an exact release: unlike actions/checkout, ruff-action
|
|
# publishes no moving major tag past v3, so @v4 does not resolve.
|
|
- uses: astral-sh/ruff-action@v4.1.0
|
|
with:
|
|
# There is no pyproject.toml for the action to read a version from,
|
|
# so pin it here: an unpinned ruff would resolve to `latest` and a
|
|
# new release could turn a green branch red on its own. Bump this
|
|
# deliberately, together with the rule set in ruff.toml.
|
|
version: 0.15.21
|
|
# Rule selection, file discovery (the many extensionless Python
|
|
# executables) and exclusions all live in ruff.toml, so the whole
|
|
# workspace can be handed over as-is.
|
|
args: check --output-format=github
|
|
|
|
python-compileall:
|
|
name: Python compileall
|
|
runs-on: ubuntu-latest
|
|
env:
|
|
# One entry per Python version shipped by the distros confluent
|
|
# targets, limited to versions actions/setup-python still provides
|
|
# on current runners (sles15/alma8 ship 3.6, which is unavailable).
|
|
# Newline-separated so it feeds both setup-python (multiline input)
|
|
# and the shell loop below (word-split on whitespace).
|
|
PYTHON_VERSIONS: |
|
|
3.8
|
|
3.9
|
|
3.10
|
|
3.12
|
|
3.13
|
|
3.14
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
- uses: actions/setup-python@v6
|
|
with:
|
|
python-version: ${{ env.PYTHON_VERSIONS }}
|
|
- name: Compile all Python files
|
|
run: |
|
|
rc=0
|
|
for v in $PYTHON_VERSIONS; do
|
|
echo "::group::Python $v"
|
|
if "python$v" -W error -m compileall -q -x '/\.git/' .; then
|
|
echo "::endgroup::"
|
|
else
|
|
echo "::endgroup::"
|
|
echo "::error::Python $v compileall failed"
|
|
rc=1
|
|
fi
|
|
done
|
|
exit "$rc"
|