mirror of
https://github.com/xcat2/confluent.git
synced 2026-09-05 04:27:56 +00:00
Markus Hilger
ba3edc2c02
A caller asking for fans or energy got nothing from any bmc that serves the Sensors collection. Those sensors were filed under their redfish reading type, Rotational for a fan, while the categories are named after the ipmi sensor types the rest of the code uses, so nothing matched. Power appeared to work only by coincidence, Power and Current happening to be spelled the same in both vocabularies. Translate the reading type as the sensor is mapped, so a sensor means the same thing whether it came from the Sensors collection, from the older Thermal and Power documents, or from ipmi. On the bmc this was found on, fans go from nothing to the 24 tachometers, and temperature and power already agreed with what the same hardware reports over ipmi. The fan controls stay out, and cannot be brought in. Their reading type is Percent, which is also what a battery state of health reports, and this bmc fills in no PhysicalContext to tell them apart, so there is nothing to classify them by that would not also drag in unrelated percentages.