xCAT/confluent
2
0
Fork 0
mirror of https://github.com/xcat2/confluent.git synced 2026-04-13 12:21:30 +00:00
Code Issues Projects Releases Wiki Activity
5,699 Commits 40 Branches 77 Tags
7cdfcd49136a0888ea5a28d84e48a8564c25da32
Commit Graph

87 Commits

Author SHA1 Message Date
Jarrod Johnson
be2ae57a38 Skip the '[' when evaluating partial ESC for terminator 2025-10-06 17:34:17 -04:00
Jarrod Johnson
3f5d96788e Fix handling of split SGR payloads 
Surprisingly frequently, the firmware stacks split right after the \x1b byte in
sending data down. Defer a dangling partial sequence until more data
comes in that should make it complete.
 2025-10-06 13:12:43 -04:00
Jarrod Johnson
17866d7657 Change to only force intense if bg == fg 
In the interest of interfering with terminal behavior as little as possible,
only apply the forced intensity if the background and foreground color are
identical and would make it otherwise literally impossible to read
when working as designed.
 2025-10-06 12:22:21 -04:00
Jarrod Johnson
a1144fd49a Auto-intense color 
Terminals seem to expect 'bold or intensity' to imply intense color.

There are certain terminals that steadfastly refuse to do bold and intense. So implement the logic on behalf of
the remote terminal.

Commonly, UEFI setup menus request bold white text on white background. This fixes such menus to be readable by explicitly requesting intense white foreground rather than normal background. For example, the kitty terminal has no 'intense on bold feature.
 2025-10-06 10:48:35 -04:00
Jarrod Johnson
f11473c736 Numerous fixes for shell server 
On exit, clear the terminal buffer and invalidate the session.  This
avoids the web ui being very attached to a closed, dead session, and
leaking stale buffer to a reused sessionid.

For confetty, treat starting a shell session more like starting a
console session.

If an attempt to resize a dead session is attempted,
ignore failures.
 2025-04-14 10:25:25 -04:00
Jarrod Johnson
b1f8cf8f12 Avoid redrawing 'powered off' redundantly. 
If the power state stays the same between queries, take no action to clear screen and
draw redundant data.

In the case of misreporting devices, it mitigates the impact of incorrect reporting,
while generally preserving the output behavior when accurate.
 2024-11-11 13:51:10 -05:00
Jarrod Johnson
ba7832eb40 Fix restoring blocking on exit 
When confetty/nodeconsole exits, correctly
clear NONBLOCK flag is an idempotent way.
 2022-09-21 09:48:39 -04:00
Jarrod Johnson
b139f9cd2c Consistently return string from consume_termdata 
If None is allowed to return, it can mess up caller.
 2021-11-05 11:30:43 -04:00
Jarrod Johnson
a7e7e647f3 Fix hang on ctrl-e,c,p,o 
Leave the function to
consume termdata if data
is available.
 2021-05-25 14:26:49 -04:00
Jarrod Johnson
9bdef5bbb9 Fix typo in confetty 2021-05-25 11:58:20 -04:00
Jarrod Johnson
df2604291d Fix refactored inline command run 
This addresses the mistake in
refactoring the inline command
shortcut
 2021-05-12 13:48:44 -04:00
Jarrod Johnson
f32a9a2f08 Rework inline command handling 
Previously, if hotkey entry
had text data come in, it
would corrupt the state of
the client.

Minimize the corruption and request the server to pause.
 2021-04-23 14:22:24 -04:00
Jarrod Johnson
e08ca5fb7e Have confetty show correct trace more easily 
In some scenarios, the quitconfetty will overwrite the
stack trace.

Get the relevant trace before trying the quitconfetty, then print
the saved trace.
 2021-04-14 10:10:44 -04:00
Jarrod Johnson
6997508a0c Fallback to forced utf8 on unicodeerror 
If LC_ALL is set to C, then unicode can be a problem.
 2021-01-21 08:41:35 -05:00
Jarrod Johnson
203253e05f Fix mispelling of exception name in confetty 2021-01-20 11:19:24 -05:00
Jarrod Johnson
a3bd21d605 Cleanup confetty/nodeconsole exit 
Unexpected exit from nodeconsole/confetty is now
handled better for feedback and terminal usefulness
 2021-01-19 16:24:36 -05:00
Jarrod Johnson
095a831c0b Fix source of abnormal console exit 
If using ctrl-e, c, then a delay while
there is console output to do,
console would crash.

Fix by catching the flush problem
and ignoring it.
 2020-06-18 13:09:48 -04:00
Jarrod Johnson
942685b48d Amend confetty fix 
shlex.join is not widely
available, switch to just
skipping the split if pre-split
by the calling process.
 2020-06-03 14:58:30 -04:00
Jarrod Johnson
21e97689bc Fix handling of complex embedded args 
If pulling from argv, it has already been
shell split. Use shlex to join to correctly
requote anything that needs quoting.
 2020-06-03 13:52:14 -04:00
Jarrod Johnson
a413f321fe Fix console loss on server exit 
Catch the new exception that
was used to make other commands
exit cleaner.
 2020-03-11 13:58:37 -04:00
Jarrod Johnson
7a63ca8759 Fix python3 problem with confetty 
Under python3, there is no unicode.
 2020-01-31 08:53:42 -05:00
Jarrod Johnson
a24866c2df Fix exitcode for confetty noderange commands 
The exitcode was not being set for noderange commands
where each node may independently raise errors.

Correct the oversight by catching each subelements errors.
 2020-01-31 08:22:20 -05:00
Jarrod Johnson
c1953bdad3 Another set of python 3 compatibility 
Numerous issues arose, particularly
when participating in a mixed
collective.
 2019-10-08 10:45:43 -04:00
Jarrod Johnson
74f18d5571 Client side py3 changes 2019-10-04 10:37:48 -04:00
Jarrod Johnson
44d6bde3ff Make /usr/bin/env python point to python2 
Same as before, more RHEL8 compatibility changes
 2019-09-23 11:04:52 -04:00
Jarrod Johnson
fbc4fc6846 Make unexpected error more specific 
Often a usable summary message is obfuscated.  Assume the subject line
is safe to relay, but continue to do a more verbose trace.
 2019-07-08 14:28:56 -04:00
Jarrod Johnson
bc995520b7 Fix confetty tab completion 
The refactoring to main caused scope of readline to be incorrect.
Pulled the scope back into namespace.
 2019-01-14 09:15:59 -05:00
Jarrod Johnson
075891bf74 Add option to confetty to help keep terminal open on early exit 
For contexts where early execution execution almost always means
some sort of error, but the terminal automatically closes,
provide a minimum time to execute option so confetty will
forcibly slow things down in such a likely scenario.
 2018-12-03 14:49:19 -05:00
Jarrod Johnson
b511a02f20 Have correct size on connect for shell session 
In addition to resize, also support initial size being set
 2018-11-26 16:21:31 -05:00
Jarrod Johnson
c60cb3a027 Implement resize from CLI client 
The CLI resize is wired up for ssh usage.  At the time of this commit,
initial size is not handled.
 2018-11-26 15:31:36 -05:00
Jarrod Johnson
9f137fa6d4 Begin work to send resize to remote 
While we do not have a path forward for auto-resize in SOL consoles,
we can provide the capability for ssh consoles.  The CLI being enabled
is of course nice, but running ssh directly is still suggested in such
a context and ultimately the Web GUI will be the most prominent
consumer of the information.
 2018-11-20 16:01:36 -05:00
Jarrod Johnson
73cab3774d Add support for volume creation 2018-10-26 14:31:28 -04:00
Jarrod Johnson
36fc23d692 Avoid VT control codes on exit through pipe 
Piped commands were subjected to terminal control sequences that
could interfere with desired operation.
 2018-09-20 11:05:00 -04:00
Jarrod Johnson
ecbe1a86b1 Revert "Have nodeconsole restore term on exit" 
This reverts commit 2972374da8.
 2018-08-02 10:27:37 -04:00
Jarrod Johnson
2972374da8 Have nodeconsole restore term on exit 2018-08-02 10:07:41 -04:00
Jarrod Johnson
5ca52ff03b Handle interruptions to select such as resize 
Resize can cause an interrupted operation on stdin, handle that.
 2018-04-09 10:48:06 -04:00
Jarrod Johnson
0b0f325240 Shorten power check interval 
The interval can be shorter with little ill-effect.
 2017-11-13 14:22:30 -05:00
Jarrod Johnson
29330aee74 Clear [powered off] from screen if state change detected 
Previously, only transition to powered on was detected.  React
to situations where data comes up or power status change.
 2017-11-13 14:04:09 -05:00
Jarrod Johnson
148329dd8e Implement send resize commands 
Craft correct stty commands based on terminal size
detected by confluent.
 2017-11-06 11:09:55 -05:00
Jarrod Johnson
d9ffa10422 Restore power query function 
Implement it in a fashion that does not block confetty while long
running power query situations happen.
 2017-11-06 10:24:32 -05:00
Jarrod Johnson
9c6b10a166 Sort output from confetty 
Sorting can greatly improve the readability of some
confluent functionality.
 2017-10-04 09:09:03 -04:00
Jarrod Johnson
563ee96879 Harden confetty to weird text strings 
If it can't properly encode to printable, use repr instead.
 2017-09-28 16:20:19 -04:00
Jarrod Johnson
9ff7829373 Fix typo in confetty 
Strings do not have a startswitch method...
 2017-08-16 15:06:48 -04:00
Jarrod Johnson
0393e55eb1 Implement API for reverse noderange 
Provide reverse noderange through special
/noderange//abbreviate location.  This should enable
collate to abbreviate noderanges.
 2017-08-14 14:41:43 -04:00
Jarrod Johnson
a3c06a00bf Fix confetty behavior when TERM not set 
Particularly in non-interactive ssh, TERM is not set.
Assume empty string if TERM is not set.
 2017-06-27 14:04:26 -04:00
Jarrod Johnson
e0cc67f57a Implement Lenovo Thinksystem and discovery support 2017-06-20 14:56:24 -04:00
Amanda Duffy
f4c191c280 Fix power off detection 2017-05-02 15:30:39 -04:00
Amanda Duffy
443b678d8a Add power off detection 2017-05-02 14:54:18 -04:00
Jarrod Johnson
43b51eec20 Be more friendly about shlex parsing errors 
If user provides bad input, be more helpful and
less fatalistic.
 2017-03-01 10:31:00 -05:00
Amanda Duffy
36bc81448e Fix missing ] and add entries to printed menu 2017-01-27 14:25:42 -05:00