From 39fb229ef1d5ba05f9ced53f04c69d6ec66b9ff6 Mon Sep 17 00:00:00 2001 From: tkucherera Date: Thu, 2 May 2024 10:29:20 -0400 Subject: [PATCH 1/2] check update args before setting anything --- confluent_client/confluent/client.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/confluent_client/confluent/client.py b/confluent_client/confluent/client.py index a7c13cd3..f9887d4e 100644 --- a/confluent_client/confluent/client.py +++ b/confluent_client/confluent/client.py @@ -705,6 +705,14 @@ def updateattrib(session, updateargs, nodetype, noderange, options, dictassign=N noderange, 'attributes/all', dictassign[key], key) else: if "=" in updateargs[1]: + update_ready = True + for arg in updateargs[1:]: + if not '=' in arg: + update_ready = False + sys.stderr.write('Error: {0} not a valid expression\n'.format(str(arg))) + exitcode = 1 + if not update_ready: + sys.exit(exitcode) try: for val in updateargs[1:]: val = val.split('=', 1) From 930ff3e20d97776223f7b9585373ef9514bcf172 Mon Sep 17 00:00:00 2001 From: tkucherera Date: Thu, 2 May 2024 10:41:30 -0400 Subject: [PATCH 2/2] fix error message --- confluent_client/confluent/client.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/confluent_client/confluent/client.py b/confluent_client/confluent/client.py index f9887d4e..a9957b96 100644 --- a/confluent_client/confluent/client.py +++ b/confluent_client/confluent/client.py @@ -595,7 +595,7 @@ def print_attrib_path(path, session, requestargs, options, rename=None, attrpref else: printmissing.add(attr) for missing in printmissing: - sys.stderr.write('Error: {0} not a valid attribute\n'.format(attr)) + sys.stderr.write('Error: {0} not a valid attribute\n'.format(missing)) return exitcode @@ -709,9 +709,9 @@ def updateattrib(session, updateargs, nodetype, noderange, options, dictassign=N for arg in updateargs[1:]: if not '=' in arg: update_ready = False - sys.stderr.write('Error: {0} not a valid expression\n'.format(str(arg))) exitcode = 1 if not update_ready: + sys.stderr.write('Error: {0} Can not set and read at the same time!\n'.format(str(updateargs[1:]))) sys.exit(exitcode) try: for val in updateargs[1:]: