From 75a5e75063a77946a678606b564cd2e73fe2c319 Mon Sep 17 00:00:00 2001 From: Markus Hilger Date: Tue, 17 Nov 2026 16:25:17 +0100 Subject: [PATCH] Log IPMI plugin stack traces to the trace log traceback.print_exc() went to stderr, where the log redirect tags every line with its caller, traceback.py, which made the traces unreadable. --- .../confluent/plugins/hardwaremanagement/ipmi.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/confluent_server/confluent/plugins/hardwaremanagement/ipmi.py b/confluent_server/confluent/plugins/hardwaremanagement/ipmi.py index f8c1e389..3b7e714c 100644 --- a/confluent_server/confluent/plugins/hardwaremanagement/ipmi.py +++ b/confluent_server/confluent/plugins/hardwaremanagement/ipmi.py @@ -18,6 +18,7 @@ import confluent.exceptions as exc from confluent.exceptions import exc_text import confluent.firmwaremanager as firmwaremanager import confluent.interface.console as conapi +import confluent.log as log import confluent.messages as msg import confluent.util as util import copy @@ -33,7 +34,6 @@ import aiohmi.ipmi.console as console import aiohmi.ipmi.command as ipmicommand import socket import ssl -import traceback import confluent.vinzmanager as vinzmanager @@ -229,9 +229,8 @@ async def _ipmi_evtloop(): waiter.send() except asyncio.CancelledError: break - except: # TODO(jbjohnso): log the trace into the log - - traceback.print_exc() + except Exception: + log.logtrace() def get_conn_params(node, configdata): @@ -495,7 +494,7 @@ async def perform_request(operator, node, element, except Exception as e: await results.put(msg.ConfluentNodeError( node, 'Unexpected Error: {0}'.format(exc_text(e)))) - traceback.print_exc() + log.logtrace() finally: await results.put('Done')