From 5d5ad821f4ebb47e4088f10d9aa2fdefa51adf2e Mon Sep 17 00:00:00 2001 From: Markus Hilger Date: Tue, 1 Sep 2026 23:51:32 +0200 Subject: [PATCH] Read health from a service that publishes no PCIe PCIeDevices and PCIeFunctions are optional, and get_health indexed both without checking. _get_adp_urls in the same file already spells it .get('PCIeDevices', []), so these two were the outliers. Power and cooling equipment has no PCIe at all. The KeyError escaped the health read and reached the user as "Unexpected Error" with a traceback behind it. Reproduces offline against DMTF's public-rackmount1 mockup. --- confluent_server/aiohmi/redfish/oem/generic.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/confluent_server/aiohmi/redfish/oem/generic.py b/confluent_server/aiohmi/redfish/oem/generic.py index b44bc253..763d0383 100644 --- a/confluent_server/aiohmi/redfish/oem/generic.py +++ b/confluent_server/aiohmi/redfish/oem/generic.py @@ -789,11 +789,14 @@ class OEMHandler(object): meminfo = sysinfo['MemorySummary'] meminfo['Name'] = 'Memory' summary['badreadings'].append(SensorReading(meminfo)) - for adapter in sysinfo['PCIeDevices']: + # Both are optional in Redfish. A PDU or a cooling unit has no + # PCIe at all, and indexing them raised KeyError out of a health + # read. + for adapter in sysinfo.get('PCIeDevices', []): adpinfo = await fishclient._do_web_request(adapter['@odata.id']) if adpinfo['Status']['Health'] not in ('OK', None): summary['badreadings'].append(SensorReading(adpinfo)) - for fun in sysinfo['PCIeFunctions']: + for fun in sysinfo.get('PCIeFunctions', []): funinfo = await fishclient._do_web_request(fun['@odata.id']) if funinfo['Status']['Health'] not in ('OK', None): summary['badreadings'].append(SensorReading(funinfo))